From 6de4908a1243b11939ef32d26a740dddcdd0389c Mon Sep 17 00:00:00 2001 From: web-padawan Date: Thu, 23 May 2019 13:28:12 +0300 Subject: [PATCH] fix: add missing focused label styles and visual test --- test/visual/default.html | 13 ++++++++++++- .../focus-tests-lumo/focus/chrome.png | Bin 0 -> 2400 bytes .../focus-tests-lumo/focus/firefox.png | Bin 0 -> 2080 bytes .../focus-tests-material/focus/chrome.png | Bin 0 -> 2076 bytes .../focus-tests-material/focus/firefox.png | Bin 0 -> 2126 bytes test/visual/test.js | 7 +++++++ theme/lumo/vaadin-checkbox-group-styles.html | 16 ++++++++++++++++ .../material/vaadin-checkbox-group-styles.html | 5 +++++ 8 files changed, 40 insertions(+), 1 deletion(-) create mode 100644 test/visual/screens/vaadin-checkbox/focus-tests-lumo/focus/chrome.png create mode 100644 test/visual/screens/vaadin-checkbox/focus-tests-lumo/focus/firefox.png create mode 100644 test/visual/screens/vaadin-checkbox/focus-tests-material/focus/chrome.png create mode 100644 test/visual/screens/vaadin-checkbox/focus-tests-material/focus/firefox.png diff --git a/test/visual/default.html b/test/visual/default.html index 204e151..3d6e0cc 100644 --- a/test/visual/default.html +++ b/test/visual/default.html @@ -4,6 +4,7 @@ + diff --git a/test/visual/screens/vaadin-checkbox/focus-tests-lumo/focus/chrome.png b/test/visual/screens/vaadin-checkbox/focus-tests-lumo/focus/chrome.png new file mode 100644 index 0000000000000000000000000000000000000000..3e88ee0fcb19e0af269c49c61e265334c9c65db8 GIT binary patch literal 2400 zcmcImYgm%m7RDyElc&q1O--84q-94+3-gkBsquoE=`kBM^EOH0ZJ}HjnSZ%ffJ$>VE8PbPGI zRJb`RUze`0BvoG3asC!y73y7HQ?CXX;~#b=0Mkh|HGN=mznG#40;L?-KMt%F?fgG2 zrEGev6qXs`Uaq+Rbe?F?shz6 zYalc5?)2OE#P+GhU4TD<%u!?3=h3as^$)+i4LDLlD$o-?#K-h%VHw^QYrRS6ggF~> zuu*nov1<>Bm|`Oj%_>8oQiP}j->A({PN~a-0Vbi|nE#DL8&t-|*i5UC7j+eT( zrJs=8{%(8|xm()!mD5m{hg3vCuvef=Y3IT@A}kTkD>Tv+@?0DHvJ`P+vn)oGLJqG( z4M-x1y`wZKjBW6&yIDM>msHZR)E{ZD>@){UYGVb8i7M>&5|*iI0RINl_nOJ!Z#(V~ zEog{vzn*G}kzps^suWd}8yz@wR-0$mMh{Ai4FivaJnMeFc%}DoC!bT$mK%jo&do+E z8MW^qB*S)Mpr4(&XQ9#2h{MG|MUMOZr5=XlOWboxI$B!FM!D;>{SE~aeK3v%X*Gyc z;U*y&c$G3tX^z;_*K=Uu(I#$C;%se@LOvhKp(9Kjx5$k7c^?Lnm4K#F7}IRlAgW!m z!g}+ZED98F4A{mHaBb(Vk7XSR!^b*x7uy99Q;-y=$nhK!Iq z*@W2Rvt3uBvL`-fb0mZQ8XCqiFlCv@{tsB9g_ZHcWu_cN5;nN+VU^85p?LIA) zhHUSyzmwu+M^@IEhXh|2qZmbRVd`v}1m!$hjc@#LIU40P;VvNQl8^zmxP7b&3~d+B&T2%5=w)laHQ{ zT>(r`)2N=WN-t8-+W#}zC_*bPMM1tloZl7o(fNT(=|KLo8(A*!{$Zb3xn;Hz) zxM_S9lkOmZ$uYOgOdSsD4y3*PQQ|?7xKc1}L9g%+xc)>#Ma*1HG2@yQv?Y8$Y7ZqN zL^_jzH#GHHp0;z<3JFgGFM=x%v*>=AC8a0`eQq^hE8|_AgpXu`k@+GI2<-rF_~C^^ zQ`Yjbfu4rANm#&F?OY0F3ob$oqJ~Izvxq^nU*Z8SOX#80mf7nQ^0smUJR)iP`3DT~ z6qO)c=WqG)Xt3MIl^gz9sV(W{chBeBjCEHP7v8Sm)V*4w7=`utDufxz&;GPHd>s%L zAZ9Y|5@SC`ObS~u-MHXaV86A!%}sB;VeHvk-$q7em|ipnPCOGoRNRO95fhPw<*8$A zj9K;$P12iH`^$yY<+R2S009bgjjMDxXyqp)@XTVxt&=yQi>m0Euf>RQc&5YFMPG-Q z_hY}FYS3oEM-~wsb2Nfxwa}@ayaTubqPfY0jZ~o0Z&zHNGTmG|OS*V!bXvx5$Ib)Km<2 z;e|ADuQ6>IjxxJ!^1{Ot*+#1B%kVQO z^lQO6pl|W4&uia71_XWPlG3Bds+!Z&mCZIpZnH7T=3^PM9dSE>{fB(TA;DLW>)q~~ zecC}BWmDt#5pg|7(hAeFe1|KRcq2h>N=fTMUbbLtF;dW&)ReX0B0uIb0gtts`%e_V zdjIRub8DNcuweyW{dB`@TW^Jb-G&=b=CVK o^lkt)K3CPRJeU9e#28nq-Lpv_g*ZuK03^uG+0&`=r_kU2226^cbpQYW literal 0 HcmV?d00001 diff --git a/test/visual/screens/vaadin-checkbox/focus-tests-lumo/focus/firefox.png b/test/visual/screens/vaadin-checkbox/focus-tests-lumo/focus/firefox.png new file mode 100644 index 0000000000000000000000000000000000000000..c5344b50aed7792423af272fea2a019fcc075469 GIT binary patch literal 2080 zcmcIl>0eV<8jdm*DuUyR>?2svqGZY{vVzMt(*FL!PQ}W5#&%bEf-Wk)944S`wRtO`qsF7<1H z&l%!kEu59-6unzB^d1fakY~9Bk#IqIEPWsrp8ehwfUj$qQcLKcADDZA@!QhPm44>F zs^h|10vBevEvXllbyreqkR5u4=I<8*0Tt;SYkzj>OY`;jkhrRrcy=z8+;N4gT zlKS~y>pZvM#e58Wk04Du0PIWU>0`6xK1H0C3k@41WrD}fswiUEq9S*w@cJSLf0BwD zoefDePg-KFZx_TRt~Ho2ng>E|nU63z+U<8oDz@t;#p=smng&XcG7 z6o)b&}6sK^ashwY+zm@ZnkxndQ) z>yi6e$o*KGqYw^JByg2auJEPP%qYetUk^|yZIfD|u8K@%!WXp?8rwc9-?Y^^<7bH6 z``a7q9}LG9AHxLfXmTKCf0Y6)y!1~4U=G?Kl54axha$qRsQDd~m62LZmc3(u3XPh{ zy1iwU(%Szc`y+hwUek-dt$Dx{v(d=8#crx|2D1A7lv&b;m|fxXg=uU=N+$){MkT_3 zh6y;ZP9cvpkaLoHZy}Zm!7yH6wXKA!`UMHXk5R^9$Z7@Cd8%sd6%l@qPzjVEwSE2M z*p3CK^XOtrcYm9>e#PH-PqrtrH>V^>h&k)rbh|aPiVQW)!a4gD_$c2!jbWXEynD`% zOrmxSeB`}rM=m9MxIC+^Qo|V2rmJhy7z_egiI7h+qp-JJ)PDgqewR%EChz8H;#AaW z{Qt_{o>9-2_jHPJ4R?JsX(&pTuDyf%^wt7Y!?hZ`7%%8wBZ!SrtQJ-Qa z5`_(~t?&Jyjx~Bazw`&JGdVMzUX)Ns8QRDro*N8SC&iD^A}1LMf&en6Imgxsxyh68z)}C)i zrCLm-pxqx8)O$t|21$s>%v$O5k;zaFtE;3o`bthM6xF+T4 z+A}Ii)DuRMC~v&%uiViPFkA77{k&b+XK4dw_1MYS#Six?B1I@))n1mi>p>9cLGCH* zeqo@kVR<;JcS1>y$K&xm%CZB(q2-rC+hrnpTwPb4rw&o}SMdr6YfG~+t33EjF1bq6ZuktA4JBL!H|jkD2aIgk=plpCQ+ z!XpXAO0NvKi(j)^?5^nlIn%%c3*W+C$dpb!rcIszs+brP9NS5jG0596)5=iIPf9&C z6rqKixm@xNSIOOk6a0}!2%61kgc@M8j_XJzB`YJl9!$Ak zrnqsfo2OaZDN9z57O^YYzf-x{H?5Q_$tj82!1&XUmWiYb!?Nm=0196sOOHTO;ho9_ z__TV{puLqd0&s3b_~5=1zl^qpq`q02IFnc{=(WA@i$LA~cItA8xmf9sRMkl}(z5ZX zrUt>=y!vB1MH{}hrsd(Gy+y6man+1&=#0+(tS2t8+5{d`pi+J1uAVKtlqn4e>v@KS z@d;~X6F_@G!l!KWm_z~|!ns}?H9j?z(2TzHd0rGypVFDE7%6%x@Arlk#|}SUr6yg4 zy{i=cG&mSvNYB1VLG9heGRf!L=4Ae3iJv@xR1Y!&H;O*{*hV-y2B~)IiTkU$6E05d zs>$Pa*^NyCNG&7tA2Db|djkRAgopsnj8Q?BQxl>}_t0LM!wcs5BC$WT3=Q1E%gy0N`*-Frf2`zbLO0Te($}{?|t6;-uFKD-uq|I zcpL25zXt+=7+`)raUKHET?YN*yLW*vFTHdY0@0tsocL!zN~vrV7s-&O>o3dGZcba9 z`M&+-*`=0CJh!W@6yv_9raN&Du9{!gZ-o|x8u%Z4vyY1~ES|Hn|2uczhoHOdyGLGI z+5hlwm)A#ft**spCsFrY&pA9Gs&M$`K|kvcg#G5vZ*^+oBWzP6aOuz22S?b%Zf!}9IiFb#$UP7uGs`Sjop!|4-6P>>QN zL*OWG%S1o_E#EU)(mh;GRHdwE$k>;IE_GI#(ow-T+mq@V5~KcsAb#=>kEb7l~8mf=)k8 zjJ-fD)riK}anqBE8|qD*i{f48hd1}DqnFSKO~dLdRQmjS=c1S5oOL{G^!GHmvMHD( z?YSXwFeh!Z5vFj$chFO$Tji8Np_c^xfiEU1!4j5dZY4vviIztdeNeo5HA^63i#>$r zTNvCqvEnn*e0XT+XQreqUh}ZHOtX-v9;b>*RRqVFm>AOhG~f3LgRXms{JUueQX{>Ga_@UIZscJRawU4@^o_{h_P8 zIvjY*Gq`rPQc-Qg$lUiaJu1|75R~)w7OS?lHjH%L-rPJU*vVr{O(9k9FA?=w;i3~AX#?&`Af5?u~sx*Ghrj5g92mY$vxVWbo&nG@K z#1t17cdAsXMnV8*kf_>NvG5>oJlf>c)rCh!Mg|knd8~_^@YGb-vW(5S#`dH8b4$@A zgm<3BaAg;mV*HQB+BShky)|Me$Mi)vAe^07d$y4-E{*OTQz>%Zm&OAUYQ=CYh>&V} za0i$-s|ml8-ydy@2~CqV#EpJ>`73l}k6M=G1{%#LIcWt+7uj^0$G1LbCrIBi(kjNa z_kvqBT--L+E4%RZ=D6r?unZK13F4wXN_tm>QETZ#UePjvEpAGegq-^Qg#~0|4%L z58%UDSd&>wQAdR~Q&@uaxf=^n!$>qO1i#bIbemHbPv!thbO7CNItNob&*f zKkyEMt6r2HP_czm#RuqJN9O()QqTSS?|X!E$%7vQ-bTEvngU^m{ss!rA1$@rKoYt? z*XJ;hNLugkbKlVypC!#`nve|}05Ol_Mige;R2~z{qCriaVz}uGgoG8M<#j=lEXYH({K~<>A$GxQE!Djv-%>pBD$BAalZ`#a#*PeF7su+qm#kgpzv}ci z%I%t)Z)w%Meg}*mJ$gj&`wJMQb67fjEDL|*#xuG<&{Z3=rvZXvW8)ZFaeKd~L2$+= z*X3hlxz)h?ieJsry58NpcgmP+*kqK z(9rM+mQ{Ivt}|j*>mau8s&|l=KEN0E_xIPb+3tO!b=gQ!5WBG4E~)l7h&T?_QHKIm z0={^5HoU98HO+=m)HjN%>5m3&*REa7LC1g}xmYFn`qrUQ=n6vs{P~;r|4*gHh&ko6 ULs{8|0t5)=U#M*A6aWAK literal 0 HcmV?d00001 diff --git a/test/visual/screens/vaadin-checkbox/focus-tests-material/focus/firefox.png b/test/visual/screens/vaadin-checkbox/focus-tests-material/focus/firefox.png new file mode 100644 index 0000000000000000000000000000000000000000..446f56c1e1a1655cf819ab747f6d56666cbd412c GIT binary patch literal 2126 zcmZuydsvcb7N;ofrq0fomN&L^9-p#kQZp4Vm1&|Sg=KDP)>Ptc)T~GXC3m)3bG)Zy zpmZa1Oex6}6}6aFMKQc0DQYI+<^@C$5QKec|LvdmyytwsbI$KO&wI|vIv#SwWP{ZP z2n1q+3_Og6K%i1^Ke)~aoY-wBKL}*qX5`_6C(|f%LSpQwINeyPL^_sdD+?ykSMHrR3v3XnINns=B zv*QL2uBPQ5Z+7Fx*sQURih8-r34PVKRl}~eI&C*37%KaKV;y*ipI7@(^W@{2a*2|O zK4I<;2;Cg{cz|vVE|413O=F<@{JjkdfgFJSFtG{(d1$uIz@2BjCJl&b=xQ$@}`-$sb;ynwpSEZS_=>|CC%e>F^= z1Tj*`XYhI2nL3J(ri&!b+jWr`2iF8&!7T)8tUd>O6b0ng=*lU$cwpS0`a< z7C))GQ6-Cu4!HCkjy~zQL|Hva_O$?;`liJ4x?sR>#Yd3jI2dHNBD6ain>J2yTAwBm^U_dom3Hf z*DlxoK(x6%GVW4u_3xdz>RG**i(BCKdgV`PJHvWHdNBGa4#hFTgL*?Iql+>f1kU%y zR}xuG`n4c?1Gl*7X<$J>x(AGK9AyW;gugquUYzlfQ=GGmpKo2VUqqtK{U5}|Tt2_8 zi!CzWfo`N1V(td@!2Z$ULZf+Ijo(hp?}Aypu)9y1(iVtJ)Sp4riIBa#Sl8Nt@S_YS zmahrTGo>vn>$)kyh1d*&7f#xnsU5Q1iCeU;({4xhb;$d3s%onEzTKK+t{5gkP@m8p zm0sQtPNPoAeD#7J?+D|?mE`Es@s8dKD<)>2>w`pRkWo&R&9v$n zHkyNlmDy?mzg;GdR(CM5gF!8FML^3^X|_kn#gSJ{we$y1JqziShWqp!;{B%-mV~e! zDMLh`?T*gl7v2k9VZ9|RWYe_MOg&d;TkKGL)B=ih!^lRi2%f|E^i9a;W6b#JO7Wsq26xl2*0K2U$WQg_>LIhP@4#6ODEg*^dLO z!isEYn zo)iE|CvwOO^G%X3b^Nnkw>DaOHqHaBXI|KJMZcmZf zOk0?26kGZifL40@_HFLh(dSMqmb@?6HtPCBTc-8$0Yhn$Xysl|qCZ10dkF{BX=`s2 zX?0i?Nn{v7$#U1WXrHVMw@`dl<$M_@aSxeEi%ETX=GZlnc;YBsV*rgST-z+)w~Egx zK6&Y}dzu;sV_fQ#IbNyrkv(MylEhnc?iuxmNdRr|@HUlFyEZy)Q|9hn6i!Ju3R+~c zv34`Dz_{qY`(thln*$0fN!%Us(Wi5H;)N=sd2X^cChrDtp2+R(w^gAl2fAcY&Sd3y z@RD~ei=P7=c_ZJXycyp@NgHAw)r76a>!i|@!cv;NRQ74L zgx>6TAS5g=blOlgi|I}mDVxoHXBcuU~oNHm @@ -33,6 +34,21 @@ color: var(--lumo-disabled-text-color); -webkit-text-fill-color: var(--lumo-disabled-text-color); } + + :host([focused]:not([disabled])) [part="label"] { + color: var(--lumo-primary-text-color); + } + + :host(:hover:not([disabled]):not([focused])) [part="label"] { + color: var(--lumo-body-text-color); + } + + /* Touch device adjustment */ + @media (pointer: coarse) { + :host(:hover:not([disabled]):not([focused])) [part="label"] { + color: var(--lumo-secondary-text-color); + } + } diff --git a/theme/material/vaadin-checkbox-group-styles.html b/theme/material/vaadin-checkbox-group-styles.html index 3d7f9d9..890a274 100644 --- a/theme/material/vaadin-checkbox-group-styles.html +++ b/theme/material/vaadin-checkbox-group-styles.html @@ -1,3 +1,4 @@ + @@ -43,6 +44,10 @@ color: var(--material-disabled-text-color); -webkit-text-fill-color: var(--material-disabled-text-color); } + + :host([focused]:not([invalid])) [part="label"] { + color: var(--material-primary-text-color); + }