New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RTL specific styles #855
Conversation
4b29ed0
to
3c151b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update one of the dropdown visual tests to have selected item, to test checkmark appearance.
I would rename "Plain template" visual test to "Selected item" and change the label accordingly, because actually that combo-box does not use any <template>
at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one weird behavior where, if you set to rtl
and back, some of the elements where still keeping themselves on rtl
mode.
Steps to reproduce:
- Open demo (eg "Presentation")
- Call
document.documentElement.setAttribute('dir','rtl')
- Open the dropdown to verify it works
- Call
document.documentElement.removeAttribute('dir')
- Open the dropdown
It will look like this (you can see by the text-field, that it's on ltr
mode):
If combo box is never opened, then switching dir
back and forth won't cause the issue. It seems to happen only after the overlay has been initialized.
The problem was coming from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Fixes #854