Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.observe in chrome to be deprecated #331

Closed
jahglow opened this issue Mar 14, 2016 · 5 comments
Closed

Object.observe in chrome to be deprecated #331

jahglow opened this issue Mar 14, 2016 · 5 comments
Milestone

Comments

@jahglow
Copy link

jahglow commented Mar 14, 2016

'Object.observe' is deprecated and will be removed in M50, around April 2016. See https://www.chromestatus.com/features/6147094632988672 for more details. vaadin-grid.min.js:166

@Juravenator
Copy link

+1

1 similar comment
@shahidify
Copy link

+1

@shahidify
Copy link

One more...
/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.

@tehapo
Copy link

tehapo commented Mar 29, 2016

We aim to remove our usage of Object.observe in a future release. To future-proof your code, I would suggest you to use the array mutation methods of Polymer to modify arrays such as grid.columns.

For example:

// With Object.observe
grid.columns.push({...});

// With Polymer array mutation method
grid.push('columns', {...});

Fortunately vaadin-grid contains a polyfill, which will be used after Chrome removes the method. So it will not break any existing functionality. Already verified this by testing in Chrome Canary.

@jouni
Copy link
Member

jouni commented Apr 14, 2016

Now that Chrome has removed this API, and the polyfill is less than great (consumes a lot of CPU), we need to drop the support for the current columns API.

As a heads-up, the current plan is to remove it in a minor version, 1.1 probably.

@manolo manolo mentioned this issue Apr 20, 2016
@Saulis Saulis added this to the v1.1.0-alpha1 milestone Apr 26, 2016
@Saulis Saulis closed this as completed Apr 26, 2016
HJK181 pushed a commit to CommerceExperts/vaadin-grid that referenced this issue Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants