Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images for sort icons should be customizable #373

Closed
kito99 opened this issue May 25, 2016 · 2 comments
Closed

Images for sort icons should be customizable #373

kito99 opened this issue May 25, 2016 · 2 comments
Labels
enhancement New feature or request

Comments

@kito99
Copy link

kito99 commented May 25, 2016

There should be custom properties exposed for sort-asc, (neutral;unsorted), and sort-desc.

@Saulis
Copy link
Contributor

Saulis commented Jun 13, 2016

Thanks for the suggestion!

For a workaround, the icons can be currently customized to some extent (in Shady DOM) using selectors like:

    vaadin-grid th.sort-asc:after {
      content: url('https://raw.githubusercontent.com/vaadin/vaadin-icons-files/master/png/arrow-circle-down.png') !important;
    }

    vaadin-grid th.sort-desc:after {
      content: url('https://raw.githubusercontent.com/vaadin/vaadin-icons-files/master/png/arrow-circle-up.png') !important;
    }

@Saulis Saulis added the enhancement New feature or request label Oct 3, 2016
@jouni jouni added the 1.x label Mar 23, 2017
@jouni
Copy link
Member

jouni commented Mar 23, 2017

Wontfix for 1.x. The upcoming 2.0 version allows you to customize the sort icons using CSS, also in native shadow DOM. See this styling example: https://cdn.vaadin.com/vaadin-grid/2.0.0-alpha4/demo/styling.html#material-design

@jouni jouni closed this as completed Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants