Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align theme parameters across the visual test files #126

Merged
merged 3 commits into from Dec 11, 2020

Conversation

tomivirkki
Copy link
Member

No description provided.

@tomivirkki tomivirkki changed the title chore: align theme parameter across the visual test files chore: align theme parameters across the visual test files Dec 9, 2020
@web-padawan
Copy link
Member

The test failure was caused by the fact that icons.html sets theme twice which throws when using const:

Uncaught SyntaxError: Identifier 'theme' has already been declared
    at icons.html:32

Reverted that one to use var. The tests will be improved as part of P3 conversion.

@web-padawan web-padawan merged commit 62334c8 into master Dec 11, 2020
1 check passed
@web-padawan web-padawan deleted the align-theme-param branch December 11, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants