From 4fc771d4e4bfe09ba00592efb34e537fd58b8902 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kari=20S=C3=B6derholm?= Date: Mon, 9 Mar 2020 10:25:45 +0200 Subject: [PATCH 1/2] fix: functionality for iOS 12 and 13 Selecting/checking a radio button did not work reliably on iOS 12 and 13. Fixes #140. --- src/vaadin-radio-button.html | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/vaadin-radio-button.html b/src/vaadin-radio-button.html index aeeb8b2..0a9330f 100644 --- a/src/vaadin-radio-button.html +++ b/src/vaadin-radio-button.html @@ -225,6 +225,10 @@ this.removeAttribute('active'); if (!this.checked && !this.disabled) { + // If you change this block, please test manually that radio-button and + // radio-group still works ok on iOS 12/13 and up as it may cause + // an issue that is not possible to test programmatically. + // See: https://github.com/vaadin/vaadin-radio-button/issues/140 this.click(); } }); @@ -251,7 +255,13 @@ * @protected */ click() { - this.shadowRoot.querySelector('input').click(); + // If you change this block, please test manually that radio-button and + // radio-group still works ok on iOS 12/13 and up as it may cause + // an issue that is not possible to test programmatically. + // See: https://github.com/vaadin/vaadin-radio-button/issues/140 + if (!this.disabled) { + this.shadowRoot.querySelector('input').dispatchEvent(new MouseEvent('click')); + } } /** @protected */ From e6933f1d2e4ce089f1d5236e0f42bb06e81d2197 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kari=20S=C3=B6derholm?= Date: Mon, 9 Mar 2020 10:44:23 +0200 Subject: [PATCH 2/2] chore(ci): use latest Firefox --- .travis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index a976d4e..d144054 100644 --- a/.travis.yml +++ b/.travis.yml @@ -8,7 +8,7 @@ cache: - node_modules addons: - firefox: "66.0" + firefox: latest chrome: stable jobs: @@ -22,12 +22,12 @@ jobs: - if: type = pull_request env: POLYMER=2 addons: - firefox: "66.0" + firefox: latest chrome: stable - if: type = pull_request env: POLYMER=3 addons: - firefox: "66.0" + firefox: latest chrome: stable - if: type = cron env: TEST_SUITE=unit_tests POLYMER=2