Skip to content

Commit 982464c

Browse files
authored
refactor: split padding-container custom CSS property in base styles (#10447)
1 parent 0d3a660 commit 982464c

File tree

23 files changed

+73
-29
lines changed

23 files changed

+73
-29
lines changed

packages/aura/src/components/accordion-details.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
:is(vaadin-details, vaadin-accordion-panel):not([theme~='no-padding'])::part(content) {
2-
padding: var(--vaadin-padding-container);
2+
padding: var(--vaadin-padding-block-container) var(--vaadin-padding-inline-container);
33
padding-top: 0;
44
}
55

packages/aura/src/size.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131
1px
3232
);
3333

34-
--vaadin-padding-container: round(var(--vaadin-padding-s) / 1.4, 1px)
35-
max(var(--vaadin-padding-s), round(var(--vaadin-radius-m) / 2, 1px));
34+
--vaadin-padding-block-container: round(var(--vaadin-padding-s) / 1.4, 1px);
35+
--vaadin-padding-inline-container: max(var(--vaadin-padding-s), round(var(--vaadin-radius-m) / 2, 1px));
3636

3737
--vaadin-gap-xs: var(--vaadin-padding-xs);
3838
--vaadin-gap-s: var(--vaadin-padding-s);

packages/button/src/styles/vaadin-button-base-styles.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export const buttonStyles = css`
2222
flex-shrink: 0;
2323
height: var(--vaadin-button-height, auto);
2424
margin: var(--vaadin-button-margin, 0);
25-
padding: var(--vaadin-button-padding, var(--vaadin-padding-container));
25+
padding: var(--vaadin-button-padding, var(--vaadin-padding-block-container) var(--vaadin-padding-inline-container));
2626
font-family: var(--vaadin-button-font-family, inherit);
2727
font-size: var(--vaadin-button-font-size, inherit);
2828
line-height: var(--vaadin-button-line-height, inherit);

packages/component-base/src/styles/style-props.js

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/dashboard/src/styles/vaadin-dashboard-widget-base-styles.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,10 @@ const widgetStyles = css`
9595
9696
/* Widget parts */
9797
header {
98-
padding: var(--vaadin-dashboard-widget-header-padding, var(--vaadin-padding-container));
98+
padding: var(
99+
--vaadin-dashboard-widget-header-padding,
100+
var(--vaadin-padding-block-container) var(--vaadin-padding-inline-container)
101+
);
99102
}
100103
101104
:host([editable]) header {

packages/date-picker/src/styles/vaadin-date-picker-overlay-content-base-styles.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const overlayContentStyles = css`
3636
font-weight: var(--vaadin-button-font-weight, 500);
3737
height: var(--vaadin-button-height, auto);
3838
line-height: var(--vaadin-button-line-height, inherit);
39-
padding: var(--vaadin-button-padding, var(--vaadin-padding-container));
39+
padding: var(--vaadin-button-padding, var(--vaadin-padding-block-container) var(--vaadin-padding-inline-container));
4040
cursor: var(--vaadin-clickable-cursor);
4141
}
4242

packages/details/src/styles/vaadin-details-summary-base-styles.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ export const detailsSummary = (partName = 'vaadin-details-summary') => css`
2424
height: var(--${unsafeCSS(partName)}-height, auto);
2525
outline: calc(var(--vaadin-focus-ring-width) * var(--_focus-ring, 0)) solid var(--vaadin-focus-ring-color);
2626
outline-offset: 1px;
27-
padding: var(--${unsafeCSS(partName)}-padding, var(--vaadin-padding-container));
27+
padding: var(
28+
--${unsafeCSS(partName)}-padding,
29+
var(--vaadin-padding-block-container) var(--vaadin-padding-inline-container)
30+
);
2831
-webkit-tap-highlight-color: transparent;
2932
-webkit-user-select: none;
3033
user-select: none;

packages/field-base/src/styles/field-base-styles.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,10 @@ export const field = css`
6363
align-self: var(--_has-label, end) var(--_no-label, start);
6464
font-size: var(--vaadin-input-field-value-font-size, inherit);
6565
line-height: var(--vaadin-input-field-value-line-height, inherit);
66-
padding: var(--vaadin-input-field-padding, var(--vaadin-padding-container));
66+
padding: var(
67+
--vaadin-input-field-padding,
68+
var(--vaadin-padding-block-container) var(--vaadin-padding-inline-container)
69+
);
6770
border: var(--vaadin-input-field-border-width, 1px) solid transparent;
6871
pointer-events: none;
6972
margin-bottom: var(--_no-label, 0)

packages/field-base/src/styles/group-base-styles.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export const group = css`
2626
}
2727
2828
:host([has-label][theme~='horizontal']) [part='group-field'] {
29-
padding: var(--vaadin-padding-container);
29+
padding: var(--vaadin-padding-block-container) var(--vaadin-padding-inline-container);
3030
padding-inline: 0;
3131
border-block: var(--vaadin-input-field-border-width, 1px) solid transparent;
3232
}

packages/grid/src/styles/vaadin-grid-base-styles.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ export const gridStyles = css`
2525
--_border-color: var(--vaadin-grid-border-color, var(--vaadin-border-color-secondary));
2626
--_row-border-width: var(--vaadin-grid-row-border-width, 1px);
2727
--_column-border-width: var(--vaadin-grid-column-border-width, 0px);
28+
--_cell-padding: var(
29+
--vaadin-grid-cell-padding,
30+
var(--vaadin-padding-block-container) var(--vaadin-padding-inline-container)
31+
);
2832
border-radius: var(--vaadin-grid-border-radius, var(--vaadin-radius-m));
2933
}
3034
@@ -383,7 +387,7 @@ export const gridStyles = css`
383387
display: block;
384388
overflow: hidden;
385389
text-overflow: ellipsis;
386-
padding: var(--vaadin-grid-cell-padding, var(--vaadin-padding-container));
390+
padding: var(--_cell-padding);
387391
flex: 1;
388392
min-height: 1lh;
389393
min-width: 0;
@@ -418,7 +422,7 @@ export const gridStyles = css`
418422
display: block;
419423
flex: 1;
420424
overflow: auto;
421-
padding: var(--vaadin-grid-cell-padding, var(--vaadin-padding-container));
425+
padding: var(--_cell-padding);
422426
outline: none;
423427
border-block: var(--_row-border-width) var(--_border-color);
424428
}
@@ -450,7 +454,7 @@ export const gridStyles = css`
450454
box-shadow:
451455
0 0 0 1px hsla(0deg, 0%, 0%, 0.2),
452456
0 8px 24px -2px hsla(0deg, 0%, 0%, 0.2);
453-
padding: var(--vaadin-grid-cell-padding, var(--vaadin-padding-container)) !important;
457+
padding: var(--_cell-padding) !important;
454458
border-radius: 3px;
455459
456460
/* Prevent overflowing the grid in Firefox */

0 commit comments

Comments
 (0)