Skip to content

chore: upgrade Playwright version to 1.56.0 #10324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

chore: upgrade Playwright version to 1.56.0 #10324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f505ce1
chore: upgrade Playwright version to 1.56.0
web-padawan Oct 14, 2025
53af6ea
test: skip number field tests for Safari 26
web-padawan Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
},
"resolutions": {
"svg2ttf": "6.0.3",
"playwright": "^1.53.0"
"playwright": "^1.56.0"
},
"lint-staged": {
"*.{js,ts}": [
Expand Down
7 changes: 4 additions & 3 deletions packages/integer-field/test/validation.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { expect } from '@vaadin/chai-plugins';
import { sendKeys } from '@vaadin/test-runner-commands';
import { fixtureSync, nextRender, nextUpdate } from '@vaadin/testing-helpers';
import { fixtureSync, isDesktopSafari, nextRender, nextUpdate } from '@vaadin/testing-helpers';
import sinon from 'sinon';
import '../src/vaadin-integer-field.js';

Expand Down Expand Up @@ -110,13 +110,14 @@ describe('validation', () => {
expect(integerField.invalid).to.be.false;
});

it('should be invalid when trying to commit an invalid number', async () => {
// Safari 26 installed since Playwright 1.56 disallows typing two minus signs
(isDesktopSafari ? it.skip : it)('should be invalid when trying to commit an invalid number', async () => {
await sendKeys({ type: '1--' });
input.blur();
expect(integerField.invalid).to.be.true;
});

it('should be valid after removing an invalid number', async () => {
(isDesktopSafari ? it.skip : it)('should be valid after removing an invalid number', async () => {
await sendKeys({ type: '1--' });
input.blur();
input.focus();
Expand Down
7 changes: 4 additions & 3 deletions packages/number-field/test/validation.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { expect } from '@vaadin/chai-plugins';
import { sendKeys } from '@vaadin/test-runner-commands';
import { fixtureSync, nextRender, nextUpdate } from '@vaadin/testing-helpers';
import { fixtureSync, isDesktopSafari, nextRender, nextUpdate } from '@vaadin/testing-helpers';
import sinon from 'sinon';
import '../src/vaadin-number-field.js';

Expand Down Expand Up @@ -151,13 +151,14 @@ describe('validation', () => {
expect(field.invalid).to.be.false;
});

it('should be invalid when trying to commit an invalid number', async () => {
// Safari 26 installed since Playwright 1.56 disallows typing two minus signs
(isDesktopSafari ? it.skip : it)('should be invalid when trying to commit an invalid number', async () => {
await sendKeys({ type: '1--' });
input.blur();
expect(field.invalid).to.be.true;
});

it('should be valid after removing an invalid number', async () => {
(isDesktopSafari ? it.skip : it)('should be valid after removing an invalid number', async () => {
await sendKeys({ type: '1--' });
input.blur();
input.focus();
Expand Down
18 changes: 9 additions & 9 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9520,17 +9520,17 @@ pkg-dir@^4.2.0:
dependencies:
find-up "^4.0.0"

playwright-core@1.53.0:
version "1.53.0"
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.53.0.tgz#bf2738cc143116b6130b78e0c644edf2e7e53ff4"
integrity sha512-mGLg8m0pm4+mmtB7M89Xw/GSqoNC+twivl8ITteqvAndachozYe2ZA7srU6uleV1vEdAHYqjq+SV8SNxRRFYBw==
playwright-core@1.56.0:
version "1.56.0"
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.56.0.tgz#14b40ea436551b0bcefe19c5bfb8d1804c83739c"
integrity sha512-1SXl7pMfemAMSDn5rkPeZljxOCYAmQnYLBTExuh6E8USHXGSX3dx6lYZN/xPpTz1vimXmPA9CDnILvmJaB8aSQ==

playwright@^1.53.0:
version "1.53.0"
resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.53.0.tgz#4eae78aa24e3c714bf71981f80b3310b838692fd"
integrity sha512-ghGNnIEYZC4E+YtclRn4/p6oYbdPiASELBIYkBXfaTVKreQUYbMUYQDwS12a8F0/HtIjr/CkGjtwABeFPGcS4Q==
playwright@^1.53.0, playwright@^1.56.0:
version "1.56.0"
resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.56.0.tgz#71c533c61da33e95812f8c6fa53960e073548d9a"
integrity sha512-X5Q1b8lOdWIE4KAoHpW3SE8HvUB+ZZsUoN64ZhjnN8dOb1UpujxBtENGiZFE+9F/yhzJwYa+ca3u43FeLbboHA==
dependencies:
playwright-core "1.53.0"
playwright-core "1.56.0"
optionalDependencies:
fsevents "2.3.2"

Expand Down