refactor: switch from part attribute to class selectors in grid #10488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
switch-from-parts-to-classes
branch
from
d08ec8b to
b8c7aa8
Compare
vursen
force-pushed
the
switch-from-parts-to-classes
branch
from
7927f77 to
7feb1a2
Compare
|
vursen
changed the title
vursen
commented
Nov 13, 2025
| <tbody id="emptystatebody"> | ||
| <tr id="emptystaterow"> | ||
| <td part="empty-state" id="emptystatecell" tabindex="0"> | ||
| <td part="empty-state" class="empty-state" id="emptystatecell" tabindex="0"> |
Contributor
Author
There was a problem hiding this comment.
I had to add a class because switching Lumo to use #emptystatecell would affect the selector specificity...
tomivirkki
approved these changes
Nov 13, 2025
web-padawan
approved these changes
Nov 14, 2025
Collaborator
|
This ticket/PR has been released with Vaadin 25.0.0-beta6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR replaces attribute selectors such as
[part~='header']with class selectors like.headerin the grid component's CSS stylesheets. This change noticebly improves performance in large complex grids by reducing style recalculation cost.Base styles (selector stats)
Before ~1.7M
After ~660K
Base styles
~35% improvement in render time:
Aura
~32% improvement in render time:
Lumo
~17% improvement in render time:
(All measurements are taken on a page with 60-column heavy grid)
Type of change