refactor: make overlay use FocusTrapController #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
commented
Dec 7, 2021
Comment on lines
-108
to
-119
| it('should not focus next focusable element inside the content when Tab is prevented', async () => { | ||
| overlay.addEventListener('keydown', (event) => { | ||
| if (event.key === 'Tab') { | ||
| event.preventDefault(); | ||
| } | ||
| }); | ||
| overlay.opened = true; | ||
| await oneEvent(overlay, 'vaadin-overlay-open'); | ||
| tabKeyDown(focusableElements[overlay._focusedIndex()]); | ||
| expect(overlay._focusedIndex()).to.equal(0); | ||
| }); | ||
|
|
There was a problem hiding this comment.
It was previously possible to prevent the focus trap logic on keydown by calling preventDefault() on the event (see the check). It was introduced as a workaround for vaadin/vaadin-rich-text-editor#125.
However, it appears that over time the mentioned issue was fixed directly in the rich text editor library as I wasn't able to reproduce it even without the workaround. Considering this, I decided to drop the workaround at all.
web-padawan
reviewed
Dec 7, 2021
vursen
force-pushed
the
refactor/make-overlay-use-focus-trap-controller
branch
from
258abb1
to
56a9ceb
Compare
tomivirkki
reviewed
Dec 7, 2021
vursen
force-pushed
the
refactor/make-overlay-use-focus-trap-controller
branch
from
85d3dc6
to
50f124e
Compare
tomivirkki
approved these changes
Dec 8, 2021
vursen
force-pushed
the
refactor/make-overlay-use-focus-trap-controller
branch
from
50f124e
to
f261503
Compare
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
vursen
force-pushed
the
refactor/make-overlay-use-focus-trap-controller
branch
from
f261503
to
51b562d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Dec 9, 2021
web-padawan
deleted the
refactor/make-overlay-use-focus-trap-controller
branch
|
This ticket/PR has been released with platform 23.0.0.alpha1 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR drops the focus trap logic from the overlay component and makes it use
FocusTrapControllerinstead.Depends on #3140
Fixes #3134
Type of change
Checklist