Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docker files out of web root #16

Open
Leopere opened this issue Jan 13, 2020 · 2 comments
Open

Move docker files out of web root #16

Leopere opened this issue Jan 13, 2020 · 2 comments

Comments

@Leopere
Copy link

@Leopere Leopere commented Jan 13, 2020

https://github.com/vabene1111/recipes/blob/develop/docker-compose.yml#L19-L20

    volumes:
    - .:/Recipes

would contain the docker-compose.yml and the Dockerfile if a hacker compromises the webapp and gains filesystem access they could modify the Dockerfile to contain anything or worse the docker-compose.yml could be modified to contain anything.

@vabene1111

This comment has been minimized.

Copy link
Owner

@vabene1111 vabene1111 commented Jan 14, 2020

Do you have a suggestion or a template on how you setup docker/compose with Django?

I did it like this honestly because it has the most ease of use for deployment and since I always use git to override all local changes when updating the container but now that this gained some interest this should probably be looked at...

@vabene1111 vabene1111 changed the title I feel uncomfortable with the docker-compose.yml and Dockerfile in the gunicorn webroot. Move docker files out of web root Jan 14, 2020
@Leopere

This comment has been minimized.

Copy link
Author

@Leopere Leopere commented Jan 14, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.