Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

6/WAKU1: Remove confirmations-enabled from status-options #139

Closed
4 tasks
Samyoul opened this issue Jun 3, 2020 · 1 comment
Closed
4 tasks

6/WAKU1: Remove confirmations-enabled from status-options #139

Samyoul opened this issue Jun 3, 2020 · 1 comment

Comments

@Samyoul
Copy link
Member

Samyoul commented Jun 3, 2020

Background

Setting confirmations-enabled in status-options data packets doesn't seem to have any functional role. Currently the confirmations-enabled setting communicates to the peer that a host will send ConfirmationRequests.

See here for details on previous discussion with @cammellos

Questions

  • Why does the node need to know that the peer will send ConfirmationRequests?
  • Should the host refuse ConfirmationRequests if the peer doesn't set the confirmations-enabled?

Proposal

  • Decide if the confirmations-enabled in status-options data packets serves a useful role
  • Decide if deprecating confirmations-enabled is desirable
  • Decide if expanding the utility of confirmations to communicate more useful info is desirable
  • Implement the agreed changes, if any, in the specs
@kdeme kdeme removed the waku-v2 label Sep 14, 2020
@oskarth oskarth changed the title Remove confirmations-enabled from status-options 6/WAKU1: Remove confirmations-enabled from status-options Mar 31, 2021
@oskarth
Copy link
Contributor

oskarth commented Mar 31, 2021

6/WAKU-1 spec not under active development, not a priority unless there is a strong need (PRs welcome in that case).

@oskarth oskarth closed this as completed Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants