New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tklib detection #15

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Aug 13, 2018

As mentioned in RT#125850, the check for tklib's existence can fail even
if the library has been installed. This change tests for the existence
of the cursor tklib package which was part of the initial tklib import
commit (https://core.tcl.tk/tklib/info/ec23b04ac240ca3c) and still
exists in the library, hence this check should now be fairly robust and
backwards compatible over (hopefully) all versions of tklib.

@@ -5,7 +5,7 @@ if {![catch {package require Tk}]} {
if {![catch {package require snit}]} {
puts {ok2}
}
if {![catch {package require tklib}]} {

This comment has been minimized.

@vadrer

vadrer Aug 13, 2018

Owner

please insert a comment stating that this is for tklib detection

@vadrer

vadrer Aug 13, 2018

Owner

please insert a comment stating that this is for tklib detection

Fix tklib detection
As mentioned in RT#125850, the check for tklib's existence can fail even
if the library has been installed.  This change tests for the existence
of the `cursor` tklib package which was part of the initial tklib import
commit (https://core.tcl.tk/tklib/info/ec23b04ac240ca3c) and still
exists in the library, hence this check should now be fairly robust and
backwards compatible over (hopefully) all versions of tklib.
@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Aug 13, 2018

Contributor

No problems :-) Have added a comment to the commit and force-pushed an update to the PR branch.

Contributor

paultcochrane commented Aug 13, 2018

No problems :-) Have added a comment to the commit and force-pushed an update to the PR branch.

@vadrer vadrer merged commit ac513f0 into vadrer:master Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment