New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Perl minimum version explicitly #16

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Aug 13, 2018

While checking the Perl minimum version value I found that some of the demo scripts were using an explicit version that was below that which was set in the Makefile.PL. Also, I noticed that although a minimum Perl version was set in the Makefile.PL (and hence in the dist's metadata), it wasn't actually set in the dist's main package. The commits in this PR bump the Perl version in the demo scripts to match that set in the dist's metadata and set the minimum version explicitly in the dist's main package so that the dist's code is consistent with its metadata.

If you'd like me to change or update anything, just let me know and I'll update and resubmit as necessary.

Show outdated Hide outdated tk-demos/widget Outdated
Show outdated Hide outdated lib/Tcl/Tk.pm Outdated
Match minimum Perl version in main package to that set for dist
The change implemented here ensures that the main package explicitly
declares the Perl version and that it is consistent with the minimum
Perl version required by the module's syntax.

@vadrer vadrer merged commit 2d0a94f into vadrer:master Aug 14, 2018

@vadrer

This comment has been minimized.

Show comment
Hide comment
@vadrer

vadrer Aug 14, 2018

Owner

thanks :):)

Owner

vadrer commented Aug 14, 2018

thanks :):)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment