Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exec bit on test files #30

Merged
merged 1 commit into from Aug 17, 2018

Conversation

@paultcochrane
Copy link
Contributor

@paultcochrane paultcochrane commented Aug 17, 2018

Test files don't need to be executable since they aren't run directly as
commands.

Test files don't need to be executable since they aren't run directly as
commands.
@vadrer vadrer merged commit f0209b0 into vadrer:master Aug 17, 2018
@chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented Aug 17, 2018

@vadrer, I don't mean to point fingers, but is there something on your end (the machine where you commit as U-CORP\konovv) that is automatically setting executable bit? I notice that some of these I executable permissions had already removed in #7 but they became executable again in later commits 150f330, 74416c6 (as well as others). There has also already been 2 PRs to unset executable bit from Makefile.PL: unset in #8, set again in 74416c6, and unset again in #13

@vadrer
Copy link
Owner

@vadrer vadrer commented Aug 18, 2018

yes, that's because I do things on windows;
so indeed executable bit will be restored afterwards

@chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented Aug 18, 2018

@vadrer setting git config core.filemode false might help, particularly if you're using Cygwin git. (I'm using Git for Windows and GitHub Desktop which seem to set core.filemode false by default.)

@vadrer
Copy link
Owner

@vadrer vadrer commented Aug 18, 2018

I knew it should something simple like that :)
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.