New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripping descriptions might move bookmarks #11

Closed
vaeth opened this Issue Nov 30, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@vaeth
Owner

vaeth commented Nov 30, 2017

The second issue mentioned in #8 should be discussed here separately.

Problem: When stripping a description, a new bookmark is created (and then the old one removed). The index where this bookmark is created was in <bookmarkdupes-2.4 calculated as the child number obtained from browser.bookmarks.getTree().

It might be more reliable to use the index stored in the node itself.
If that index exists, this is used instead in bookmarksdupes-2.4.

@vaeth

This comment has been minimized.

Owner

vaeth commented Dec 23, 2017

I think everything possible has been done to communicate the problem (which seems unsolvable with the current bookmark API).

Therefore, I am closing this bug for the moment.

@vaeth vaeth closed this Dec 23, 2017

vaeth pushed a commit that referenced this issue Jan 24, 2018

Merge pull request #11 from vaeth/master
Actualización del repositorio padre.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment