Network creation is probably not thread safe (and errors out). #104

Closed
purpleidea opened this Issue Dec 12, 2013 · 5 comments

Comments

Projects
None yet
3 participants
Contributor

purpleidea commented Dec 12, 2013

Hi, I've written a write up of vagrant-libvirt on Fedora 19 [1].

Here is one bug (and workaround) that I found. Fixes upstream would be awesome!
I was asked to report it:

Running vagrant up caused some errors when more than one machine is defined. This was caused by duplicate attempts to create the same network. To work around this, you can either start each virtual machine manually, or use the –no-parallel option when the network is first created:
$ vagrant up --no-parallel
[...]

[1] https://ttboj.wordpress.com/2013/12/09/vagrant-on-fedora-with-libvirt/

Cheers,
James

Owner

pronix commented Dec 18, 2013

hello @purpleidea
which errors ?

Contributor

purpleidea commented Dec 18, 2013

Hey,

You're right, I didn't save the errors. Sorry!
Should be easy enough to reproduce. It's a standard libvirt can't create network sort of error, and then whichever guest host was making that, dies and doesn't continue (vagrant error).

Collaborator

sciurus commented Jan 13, 2014

I have a fix for this in my branch safe_parallel_networks. That branch also incorporates my fix for #102. Testing is appreciated.

Collaborator

sciurus commented Jan 17, 2014

I'm going to rework this to use a mutex to lock the network checking and activation.

Collaborator

sciurus commented Jan 18, 2014

Locking work is done in the pull request,

pronix closed this in 1aabe66 Jan 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment