New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coding of arch to x86_64 in domain template prevents the plugin to work with libvirt/KVM on non-x86 architecture #286

Closed
bpradipt opened this Issue Dec 15, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@bpradipt

bpradipt commented Dec 15, 2014

The domain.xml.erb hard-codes the arch attribute under OS tag to x86_64.

<type arch='x86_64'>hvm</type>

This prevents using this plugin to manage non-x86_64 architecture like Power(ppc64) and Arm. KVM and libvirt is available for these architectures as well.
With recent libvirt, the 'arch' attribute is actually not required, since it defaults to the host architecture on which the daemon is running.

So a simple fix is to remove the arch attribute from the template. Another option is to make this configurable via the Vagrantfile.

I tested without the arch field on both x86/KVM and ppc64/KVM successfully.

@bpradipt bpradipt changed the title from Hard coding of arch to x86_64 in domain template prevents the plugin to work with KVM on non-x86 architecture to Hard coding of arch to x86_64 in domain template prevents the plugin to work with libvirt/KVM on non-x86 architecture Dec 15, 2014

@sciurus

This comment has been minimized.

Show comment
Hide comment
@sciurus

sciurus Dec 15, 2014

Collaborator

Makes sense. Could you submit a PR that removes the arch attribute?

Collaborator

sciurus commented Dec 15, 2014

Makes sense. Could you submit a PR that removes the arch attribute?

@bpradipt

This comment has been minimized.

Show comment
Hide comment
@bpradipt

bpradipt Dec 15, 2014

Done . Thanks
#287

bpradipt commented Dec 15, 2014

Done . Thanks
#287

@sciurus

This comment has been minimized.

Show comment
Hide comment
@sciurus

sciurus Dec 27, 2014

Collaborator

Thanks! Sorry it took me a while to test and merge it.

Collaborator

sciurus commented Dec 27, 2014

Thanks! Sorry it took me a while to test and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment