Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle REXML requires for Ubuntu focal #1584

Merged

Conversation

electrofelix
Copy link
Contributor

The distribution provided vagrant package on Ubuntu 20.04 is version
2.2.6 running on ruby 2.7.2. It appears that the rexml layout is
slightly different and imports different paths than the current code
expects. Add this combination to the unit tests and switch the requires
to load the specific library requirements instead of relying on rexml
loading everything underneath.

Additionally it appears the hook behaviour change appeared earlier that
the understood vagrant release of 2.2.11, and 2.2.6 also requires the
newer hook behaviour.

The distribution provided vagrant package on Ubuntu 20.04 is version
2.2.6 running on ruby 2.7.2. It appears that the rexml layout is
slightly different and imports different paths than the current code
expects. Add this combination to the unit tests and switch the requires
to load the specific library requirements instead of relying on rexml
loading everything underneath.

Additionally it appears the hook behaviour change appeared earlier that
the understood vagrant release of 2.2.11, requiring the same behaviour
for 2.2.10.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 79.513% when pulling babfc9e on electrofelix:support-distro-vagrant-focal into 602b4e9 on vagrant-libvirt:main.

@electrofelix electrofelix marked this pull request as ready for review September 8, 2022 11:43
@electrofelix electrofelix merged commit ba2c7be into vagrant-libvirt:main Sep 8, 2022
@electrofelix electrofelix deleted the support-distro-vagrant-focal branch September 8, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants