Add multi-arch support #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the domain template as defined in domain.xml.erb hard-codes the arch attribute under OS tag to x86_64. This is really not required since the 'arch' attribute is automatically populated by libvirt <type arch='x86_64'>hvm</type> This prevents using this plugin to manage non-x86_64 architecture like Power(ppc64) and Arm. This patch removes the 'arch' attribute from the domain template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the domain template as defined in domain.xml.erb hard-codes the arch
attribute under OS tag to x86_64. This is really not required since the
'arch' attribute is automatically populated by libvirt
<type arch='x86_64'>hvm</type>This prevents using this plugin to manage non-x86_64 architecture like
Power(ppc64) and Arm.
This patch removes the 'arch' attribute from the domain template