Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qemu Session Support #868

Merged
merged 3 commits into from Mar 17, 2018
Merged

Qemu Session Support #868

merged 3 commits into from Mar 17, 2018

Conversation

qazokm
Copy link
Contributor

@qazokm qazokm commented Feb 23, 2018

Added basic qemu support in response to issue #272. The patch supports creating storage pools under user directories and using existing networks created under the qemu:///system connection. Using existing networks requires the qemu-bridge-helper to be installed and the relevant permissions granted (this is the default on some distros but others may need to configure this).

To assist with this the following configuration options where added

  • qemu_use_session
    • Enable usage of qemu session, changes default connection URL to qemu:///session and enables support for qemu session
  • storage_pool_path
    • Storage pool path to use for libvirt images
    • Defaults to /var/lib/libvirt/images
    • If session enabled defaults to ~/.local/share/libvirt/images)
  • management_network_device
    • Device to use for management network
    • Defaults to 'virbr0'
  • system_uri
    • QEMU system URL to connect to as read-only to retrieve DHCP leases for obtaining IP addresses

@pronix
Copy link
Member

pronix commented Feb 23, 2018

hello @qazokm
thanks for huge impact. it will take time for testing.
can you also add some information to README, for example same as in description.
thank you

@qazokm
Copy link
Contributor Author

qazokm commented Feb 25, 2018

No problem, added a basic example with links to QEMU bridge helper information

@pronix pronix merged commit 066e03f into vagrant-libvirt:master Mar 17, 2018
@pronix
Copy link
Member

pronix commented Mar 17, 2018

@qazokm thank you. check please some changes 99371fe

@little-dude
Copy link

Thanks a lot for this @qazokm. It would be nice to have a release with this.

@voxik
Copy link
Contributor

voxik commented Oct 18, 2018

@qazokm nice work 👍 but have you considered to submit part of your changes to fog-libvirt? E.g. default_storage_volume.xml.erb would not be needed here if the owner and group tags were supported by fog-libvirt and on the first look, it just looks it would be just a minor change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants