Add optional deadline feature #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vaishnav-sh, can you please review my code and give some feedbacks if there are some needs to change? |
hlavu
changed the title
|
hey! I have seen your email and I'm sorry it took some time for me to reply as I was ill. This feature can be really handy but UI wise could you make some improvements? |
|
Hi @vaishnav-sh, I am so sorry to hear that. Hope you feel better soon.
After the
|
|
Hi @vaishnav-sh, please give feed back for this PR. |
|
Sorry! This PR cannot be merged as the UI doesn't match the look of the project. Feel free to raise any other issue and I'll be happy to assign you. Thank you for contributing! but for now I will close this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vaishnav-sh, I have added the deadline feature for the app. Please take a look and let me know if you want any change.
Here are some screen shots of the app. #29