Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighter stops working after using Obsidian/markdown quotes inside admonition #74

Closed
mikkovedru opened this issue Aug 11, 2021 · 9 comments

Comments

@mikkovedru
Copy link

@mikkovedru mikkovedru commented Aug 11, 2021

How to reproduce the bug

  1. Add 3 test lines inside the admonition:
    image
  2. Use Obsidian/markdown quote feature(>) on the second line. BUG: Notice that syntax highlighter stopped working on all the lines even below the quoted one.
    image

Other interesting detail

Putting a code block returns highlighting back to normal.
image

Versions

  • Obsidian 0.12.10
  • Admonition 6.2.2
@valentine195
Copy link
Owner

@valentine195 valentine195 commented Aug 11, 2021

I think this is the default behavior for the hypermd CodeMirror syntax highlighter inside a code block. Not sure I'll be able to fix this unfortunately.

@mikkovedru
Copy link
Author

@mikkovedru mikkovedru commented Sep 8, 2021

@valentine195
I reported the bug to the Obsidian developers, and they answered:

This is third-party plugin problem. We don’t provide user support for user problems of third party plugins.

It’s up to the third party author to debug the issue and if the issue is due to Obsidian core report to the dev.

Is there something I can do to help this issue to be fixed?

@valentine195
Copy link
Owner

@valentine195 valentine195 commented Sep 8, 2021

Hi,

By CodeMirror issue, I meant that this behavior occurs in the hypermd language highlighter (which is what this plugin uses).

image

@mikkovedru
Copy link
Author

@mikkovedru mikkovedru commented Sep 10, 2021

@valentine195
I am utterly confused as to where exactly this bug is and who is responsible.

I reported this bug to the CodeMirror developers, but they are confused as well:

marijnh 9 hours ago

I don't know what hypermd is, but there's no support for it anywhere in this library.

@valentine195
Copy link
Owner

@valentine195 valentine195 commented Sep 10, 2021

I think HyperMD may be this.

https://github.com/laobubu/HyperMD

But yes, I understand that it's annoying. However, HyperMD is the language highlighter that Obsidian uses to highlight its markdown in edit mode. This same behavior happens in that language highlighter, which means there's nothing I can do, because this plugin just uses that language highlighter.

@mikkovedru
Copy link
Author

@mikkovedru mikkovedru commented Sep 10, 2021

I just want to know where this bug is located and want to report it to the appropriate party.

It was confusing, because you mentioned CodeMirror, but the bug had nothing to do with them.

Thank you for pointing me in the right direction. 👍

@valentine195
Copy link
Owner

@valentine195 valentine195 commented Sep 10, 2021

It was confusing, because you mentioned CodeMirror, but the bug had nothing to do with them.

Yep... I didn't realize HyperMD was a separate thing 🤷🏼 Sorry about that!

@mikkovedru
Copy link
Author

@mikkovedru mikkovedru commented Sep 10, 2021

Yep... I didn't realize HyperMD was a separate thing 🤷🏼 Sorry about that!

No problem, mate. :-)

Thank you for the quick replies and a great job with a lovely plugin that became an essential part of my everyday life! :-)

@valentine195
Copy link
Owner

@valentine195 valentine195 commented Oct 4, 2021

I'm gonna close this, hopefully HyperMD will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants