Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.0: Two maps in one note: first loses markers? #36

Closed
Moonbase59 opened this issue May 5, 2021 · 3 comments
Closed

3.1.0: Two maps in one note: first loses markers? #36

Moonbase59 opened this issue May 5, 2021 · 3 comments

Comments

@Moonbase59
Copy link

@Moonbase59 Moonbase59 commented May 5, 2021

Upon doing a quick test, I found that when adding a new (test) map to an existing map note, the first map lost all its markers? My mistake?

First map in the note (losing its markers):

id: Friends
markerFolder: People/Friends & Family
markerFolder: +Inbox
height: 500px
lat: 51.133333
long: 10.416667
minZoom: 1
maxZoom: 18
defaultZoom: 5

Second (test) map in this note (working):

id: Test
markerFolder: People/Friends & Family
markerTag: #family 
markerTag: #friends, #test 
height: 500px
lat: 51.133333
long: 10.416667
minZoom: 1
maxZoom: 18
defaultZoom: 5

EDIT: Deleting the second map and closing/reopening the note (to circumvent caching) didn’t bring back the markers on the first map.

See also: https://forum.obsidian.md/t/new-plugin-obsidian-leaflet-interactive-maps-in-notes/14752/56?u=moonbase59

@valentine195
Copy link
Owner

@valentine195 valentine195 commented May 5, 2021

Okay, I know why the first map lost its markers - it's not due to the second map at all, just an oversight on how the plugin handles no markerTag parameter. Should have a fix out soon.

@valentine195
Copy link
Owner

@valentine195 valentine195 commented May 5, 2021

Could you verify 3.1.1 fixes this?

@valentine195 valentine195 reopened this May 5, 2021
@Moonbase59
Copy link
Author

@Moonbase59 Moonbase59 commented May 5, 2021

Maybe, but you’re too fast! Fixed in 3.2.1. You’re my current hero!

@Moonbase59 Moonbase59 closed this May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants