Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support or syntax #6

Merged
merged 2 commits into from Apr 25, 2018

Conversation

Projects
None yet
3 participants
@paulovitin
Copy link
Contributor

commented Apr 24, 2018

Why
Sometimes you has a menu and a tab menu in internal page, and you need check the tab menu and the parent menu.

How
Add to the view-names string a support to || (two pipes), we can write checks like bellow:

<a class="{% active_link 'view-tab-one || view-tab-two' %}">Menu</a>
<a class="{% active_link 'view-tab-one' %}">Tab One</a>
@codecov-io

This comment has been minimized.

Copy link

commented Apr 24, 2018

Codecov Report

Merging #6 into master will increase coverage by 1.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   89.65%   91.17%   +1.52%     
==========================================
  Files           3        3              
  Lines          29       34       +5     
  Branches        6        8       +2     
==========================================
+ Hits           26       31       +5     
  Misses          3        3
Impacted Files Coverage Δ
active_link/templatetags/active_link_tags.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 902ed35...ce48b2d. Read the comment docs.

@valerymelou valerymelou merged commit 34c430a into valerymelou:master Apr 25, 2018

3 checks passed

codecov/patch 100% of diff hit (target 89.65%)
Details
codecov/project 91.17% (+1.52%) compared to 902ed35
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@valerymelou

This comment has been minimized.

Copy link
Owner

commented Apr 25, 2018

Nice one. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.