New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

einen reisen großen Dank an @pohli wo die zahlreiche Tippfehler behoben hat #1511

Merged
merged 2 commits into from Sep 5, 2018

Conversation

Projects
None yet
3 participants
@kevinkreiser
Member

kevinkreiser commented Sep 5, 2018

danke noch mal @Pohli
fixes #1510

@kevinkreiser kevinkreiser requested a review from dgearhart Sep 5, 2018

@dgearhart

LGTM

@kevinkreiser kevinkreiser merged commit 7d990c5 into master Sep 5, 2018

6 checks passed

ci/circleci: build-debug Your tests passed on CircleCI!
Details
ci/circleci: build-osx Your tests passed on CircleCI!
Details
ci/circleci: build-release Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 81.49%)
Details
codecov/project 81.49% (+0%) compared to eea723c
Details
@Pohli

This comment has been minimized.

Pohli commented Sep 6, 2018

missed one of the metric lengths not getting translated from english

Now I see! That's why Pure Maps with German directions always say "Meters" instead of "Meter" (which is the correct plural form of Meter in German language). In the beginning it was funny but now it's more and more getting annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment