fix a regresion introduced in #2743 #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gknisely
approved these changes
Jan 27, 2021
kevinkreiser
commented
Jan 27, 2021
| @@ -104,7 +104,8 @@ bool TimeDepForward::ExpandForward(GraphReader& graphreader, | |||
| // if this is a downward transition (ups are always allowed) AND we are no longer allowed OR | |||
| // we cant get the tile at that level (local extracts could have this problem) THEN bail | |||
| graph_tile_ptr trans_tile = nullptr; | |||
| if ((!trans->up() && hierarchy_limits_[trans->endnode().level()].StopExpanding()) || | |||
| if ((!trans->up() && | |||
| hierarchy_limits_[trans->endnode().level()].StopExpanding(pred.distance())) || | |||
There was a problem hiding this comment.
in the previous PR i accidentally removed the distance argument 🤦
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some optimizations in #2743 but made a very important typo when doing so. I missed that the function call we used for timedependent algorithms to stop downward expansion was the one that took the predecessory labels distance. This caused the router to cull search space that was needed for it to find the destination (or origin in the reverse search)