Gitea helm #174
Closed
Gitea helm #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added namespaces and secrets RBAC to the giteaserver_controller.go - //+kubebuilder:rbac:groups=core,resources=namespaces,verbs=get;create - //+kubebuilder:rbac:groups=core,resources=secrets,verbs=get;list;watch;create;update;patch;delete - Fixed issues with isChartDeployed function - Updated pattern_controller.go to use ReconcileLoopRequeueTime from defaults
- Added route scheme to main.go - Added getRoute function to kube.go - Updated isChartDeployed function - Added updateGiteaServerCRDetails function
- Added finalizeObject function - Added finalizer code to reconciler - Updated default variable name for Repo_Url
…deletion of namespaces - Added new deleteNamespace function - Updated finalizer logic in the giteaserver_controller
- Added constants to defaults to fix lint issues - Added nolint directives to fix lint issues - Added return types to helm functions - Renamed function arguments to correct lint errors - Renamed debug function to debugf per lint suggestions
…utes - Added Version to the GiteaServer CRD - Added logic for the gitea_admin password as an override to the main gitea chart - Added default value for the gitea chart version. - Added version as an argument to the Helm InstallChart function. - Added the generateStringPassword function in utils.
- Updated use of default values in controllers and util functions
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaldessari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mbaldessari
commented
Jan 31, 2024
| import ( | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| ) | ||
|
|
Comment on lines
+22
to
+23
| k8s.io/api v0.29.0 | ||
| k8s.io/apimachinery v0.29.0 |
Contributor
Author
There was a problem hiding this comment.
Not needed as it will be replaced below anyway
| github.com/onsi/ginkgo/v2 v2.13.2 | ||
| github.com/onsi/gomega v1.30.0 | ||
| github.com/openshift/api v0.0.0-20231130225947-f2209623068b | ||
| github.com/openshift/api v0.0.0-20240118221011-59fa376de7cb |
Contributor
Author
There was a problem hiding this comment.
Is this update needed? If not best keep it for a separate pr?
claudiol
added a commit
to claudiol/patterns-operator
that referenced
this pull request
Feb 3, 2024
mbaldessari
pushed a commit
to mbaldessari/patterns-operator
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.