Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow roles search and presentation on form element #193

Closed
stevefaulkner opened this issue Dec 16, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@stevefaulkner
Copy link
Contributor

commented Dec 16, 2015

after discussion, and me being disabused on AT usage, allowed search role on form element
w3c/html-aria#18

@EricDunsworth

This comment has been minimized.

Copy link

commented Feb 1, 2016

@sideshowbarker Should this issue be re-opened?

<form role="search"> is still triggering validation errors beyond commit 091e38f :(. 16.1.1's changelog claims it was fixed, but it's still happening in the newer version (16.1.30) that's currently in use on https://validator.w3.org/nu/.

Sample HTML code:

<!DOCTYPE html>
<html>
<head>
<title>Test</title>
</head>
<body>
<form role="search"></form>
</body>
</html>

Error:

Error: Bad value search for attribute role on element form.

From line 7, column 1; to line 7, column 20

d>↩<body>↩<form role="search"></form
``
@sideshowbarker

This comment has been minimized.

Copy link
Member

commented Feb 2, 2016

Should this issue be re-opened?

Yup, thanks for catching it. Not sure why the change I made isn't having the expected effect, but I'll investigate.

@sideshowbarker sideshowbarker reopened this Feb 2, 2016

@Anydog

This comment has been minimized.

Copy link

commented Feb 12, 2016

We still have validator reporting error for role=search on form element. Should I simply remove this attribute ?

@sideshowbarker

This comment has been minimized.

Copy link
Member

commented Feb 12, 2016

We still have validator reporting error for role=search on form element.

I’ve not actually fixed it yet.

Should I simply remove this attribute ?

I’d suggest keeping it and checking back in a couple days (after I’ve made time to fix it).

@sideshowbarker

This comment has been minimized.

Copy link
Member

commented Feb 20, 2016

@EricDunsworth

This comment has been minimized.

Copy link

commented Feb 22, 2016

@sideshowbarker Thanks :)!

tripu added a commit to tripu/validator that referenced this issue Aug 19, 2016

Sync up with latest ARIA-in-HTML spec changes
This allows role=group for <header> & <footer>, and role=search for <form>.

Fixes validator#185. Fixes validator#193.

tripu added a commit to tripu/validator that referenced this issue Aug 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.