Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
CSS variables flagged as Parse Error #644
I tried it with both sites and I get the same results (more errors on checker.html5.org). Here's the site I tested it with: https://www.jeromes.com. It has minified, inlined CSS, with fairly complex calc()s for computing varying flex layouts with gutters.
Rather than trying to interpret that, here's a tiny test that fails the same way:
Regardless of the validator's report, Chrome is able to interpret this properly.
OK, thanks, yeah looking at the following:
…I see the specific problem seems to be with handling of
However, I think there are other cases that can still fail, and I’m not super-confident the change I made doesn’t introduce any regressions or otherwise have unintended side effects.
The thing is, the current CSS variables “support” in the checker is a kind of crude hack that’s just meant as an interim workaround until we manage to get it implemented in the right way. I’m still a bit surprised I managed to get it working at all…
But anyway, if it works at least for the documents you’re checking, then I guess we could go ahead and close this issue. So lemme know.
And then If you later run into a case later that it doesn’t work for, then you could open up a new issue.
OK — I’ll go ahead and close this.
Thanks much for having taken time to report the problem. I’m glad I was able to actually fix it for your cases with a relatively minimal amount of re-wrestling with the code.
Anyway, if/when you do run into any new cases that it chokes on, please open new issues.