Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix el-GR isTaxID when checksum is 10 #1529

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

dspinellis
Copy link
Contributor

@dspinellis dspinellis commented Nov 25, 2020

feat(isTaxID): Add correct tax identifier to demonstrate issue and fix.

Thanks to: Panos Papadopoulos

  • Add test case to demonstrate problem
  • Limit checksum result to single digit to fix the validation

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@profnandaa
Copy link
Member

Can fix the failing test?

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Nov 29, 2020
Add correct tax identifier to demonstrate issue and fix.

Thanks to: Panos Papadopoulos
@dspinellis
Copy link
Contributor Author

The PR includes both a (previously failing) test and a fix. If you mean the failing CI run, I have rebased the commit on top of its earlier fix, so that should be OK now.

@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #1529 (421d077) into master (0f8e597) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1529   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           99        99           
  Lines         1773      1773           
=========================================
  Hits          1773      1773           
Impacted Files Coverage Δ
src/lib/isTaxID.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8e597...421d077. Read the comment docs.

@profnandaa profnandaa added ready-to-land For PRs that are reviewed and ready to be landed and removed 🧹 needs-update For PRs that need to be updated before landing labels Nov 30, 2020
@ezkemboi
Copy link
Member

@profnandaa this is good to go. I think so.

@profnandaa profnandaa merged commit 8831db3 into validatorjs:master Dec 17, 2020
profnandaa pushed a commit that referenced this pull request Feb 15, 2021
* chore: prevent git from ignoring src/index.js file

* chore: remove unused exclusion from nyc config

* chore: replace travis-ci with github actions

* chore: fix issue with github workflow config

* chore: fix condition for coverage generation and sending

* chore: treat node version as int

* docs: replace travis with github actions badge

* chore: add npm publish github action

* chore: remove auto-generated files

* chore: improve github actions styles

* chore: use correct repo url to prevent unecessary redirect

* chore: lint package.json file

* chore: add new line at end of file

* feat(isMobilePhone): update de-CH, add fr-CH, it-CH locales (#1554)

* fix(isMobilePhone): update de-CH locale (#1549)
feat(isMobilePhone): add fr-CH locale (#1549)
feat(isMobilePhone): add it-CH locale (#1549)

* fix(isMobilePhone): update de-CH, fr-CH and it-CH locale in validator.min.js(#1549)

* fix(isMobilePhone): update fr-CH and it-CH locale aliases (#1549)

Co-authored-by: Ashutosh Kumar <kumar.ashutosh@siemens.com>

* feat(isLicensePlate): new validator 🎉 (#1495)

* Added isLicensePlate check with german locale

* de-LI (Liechtenstein) validator

* Added albanian number plates

* reversed changes in index.js

* reversed changes in index.js

* Refactored de-DE into one big regex, expanded tests fot de-DE

* added pt-PT locale

* Fixed coverage problem

* feat(isLicensePlate): clean build

* coverage is now 100%

* Update README.md

* Update README.md

* fix(isTaxID): fix el-GR locale when checksum is 10 (#1529)

Add correct tax identifier to demonstrate issue and fix.

Thanks to: Panos Papadopoulos

* feat(isMobileNumber): add support new telco numbers for VN locale (#1575)

* Support new VN mobile phone 087 (https://didong.itelecom.vn/)

* Add test for new telco number

Co-authored-by: Kyle Dinh <kyle@Kyles-Mac-mini.telio>

* chore: set a fixed ubuntu version instead of relying on latest

Co-authored-by: Ashutosh Kumar <dinfekted@users.noreply.github.com>
Co-authored-by: Ashutosh Kumar <kumar.ashutosh@siemens.com>
Co-authored-by: Michael Firlus <michael@4lus.de>
Co-authored-by: Diomidis Spinellis <dds@aueb.gr>
Co-authored-by: Kyle Dinh <kyled7@users.noreply.github.com>
Co-authored-by: Kyle Dinh <kyle@Kyles-Mac-mini.telio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants