From 542db1c31fd47928d09fd8c3bc731636daa86a53 Mon Sep 17 00:00:00 2001 From: Beck <164545837+validbeck@users.noreply.github.com> Date: Mon, 2 Dec 2024 16:28:34 -0800 Subject: [PATCH] Fixing on the fly notebook execution filter (#559) * I'm strong * Removing the comment from notebooks/README.md --- .github/workflows/deploy-docs-prod.yaml | 5 +++-- .github/workflows/deploy-docs-staging.yaml | 5 +++-- .github/workflows/validate-docs-site.yaml | 3 ++- site/notebooks/README.md | 4 +--- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/deploy-docs-prod.yaml b/.github/workflows/deploy-docs-prod.yaml index d6751de1df..ca7ffcb9d8 100644 --- a/.github/workflows/deploy-docs-prod.yaml +++ b/.github/workflows/deploy-docs-prod.yaml @@ -31,12 +31,13 @@ jobs: } # See if site/notebooks/ has updates + # Checks against the previous commit to the branch prior to the current push event - name: Filter changed files uses: dorny/paths-filter@v2 id: filter with: - base: prod - ref: ${{ github.head_ref }} + base: ${{ github.event.before }} + ref: ${{ github.sha }} filters: | notebooks: - 'site/notebooks/**' diff --git a/.github/workflows/deploy-docs-staging.yaml b/.github/workflows/deploy-docs-staging.yaml index 261c20e9e2..9c69cb00d9 100644 --- a/.github/workflows/deploy-docs-staging.yaml +++ b/.github/workflows/deploy-docs-staging.yaml @@ -31,12 +31,13 @@ jobs: } # See if site/notebooks/ has updates + # Checks against the previous commit to the branch prior to the current push event - name: Filter changed files uses: dorny/paths-filter@v2 id: filter with: - base: staging - ref: ${{ github.head_ref }} + base: ${{ github.event.before }} + ref: ${{ github.sha }} filters: | notebooks: - 'site/notebooks/**' diff --git a/.github/workflows/validate-docs-site.yaml b/.github/workflows/validate-docs-site.yaml index fee4b819cc..44d83dc5ff 100644 --- a/.github/workflows/validate-docs-site.yaml +++ b/.github/workflows/validate-docs-site.yaml @@ -30,11 +30,12 @@ jobs: } # See if site/notebooks/ has updates + # Checks the current PR branch against the target branch - name: Filter changed files uses: dorny/paths-filter@v2 id: filter with: - base: main + base: ${{ github.event.pull_request.base_ref }} ref: ${{ github.head_ref }} filters: | notebooks: diff --git a/site/notebooks/README.md b/site/notebooks/README.md index 5e117aa97e..9954d5a272 100644 --- a/site/notebooks/README.md +++ b/site/notebooks/README.md @@ -18,6 +18,4 @@ ValidMind enables organizations to identify, document, and manage model risks fo If this is your first time trying out ValidMind, you can make use of the following resources alongside our sample notebooks: - [Get started](https://docs.validmind.ai/get-started/get-started.html) — The basics, including key concepts, and how our products work -- [Get started with the ValidMind Library](https://docs.validmind.ai/developer/get-started-validmind-library.html) — The path for developers, more code samples, and our developer reference - - \ No newline at end of file +- [Get started with the ValidMind Library](https://docs.validmind.ai/developer/get-started-validmind-library.html) — The path for developers, more code samples, and our developer reference \ No newline at end of file