-
Notifications
You must be signed in to change notification settings - Fork 3
Transaction commands #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction commands #137
Conversation
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Don't forget to address CI failure.
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
currantw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
Signed-off-by: Alex Rehnby-Martin <alex.rehnby-martin@improving.com>
currantw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a couple documentation updates from previous changes.
Adds support for WATCH and UNWATCH commands. These are used in conjunction with existing Batch/Transaction functionality, with tests of this behaviour.