Skip to content

Support MPTCP for valkey-cli and benchmark - #2067

Merged
zuiderkwast merged 1 commit into
valkey-io:unstablefrom
pizhenwei:mptcp-cli
May 9, 2025
Merged

Support MPTCP for valkey-cli and benchmark#2067
zuiderkwast merged 1 commit into
valkey-io:unstablefrom
pizhenwei:mptcp-cli

Conversation

@pizhenwei

@pizhenwei pizhenwei commented May 9, 2025

Copy link
Copy Markdown
Contributor

Add '--mptcp' for both valkey-cli and valkey-benchmark to enable MPTCP.

MPTCP is supported by both valkey and libvalkey.

Doc: valkey-io/valkey-doc#274

Cc @matttbe @geliangtang

MPTCP is supported by both valkey and libvalkey, add '--mptcp' for
both valkey-cli and valkey-benchmark to enable MPTCP.

Signed-off-by: zhenwei pi <zhenwei.pi@linux.dev>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
@pizhenwei
pizhenwei requested a review from zuiderkwast May 9, 2025 10:59

@zuiderkwast zuiderkwast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zuiderkwast zuiderkwast added the release-notes This issue should get a line item in the release notes label May 9, 2025
@codecov

codecov Bot commented May 9, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.00%. Comparing base (70106f0) to head (fa7ccf2).
Report is 1 commits behind head on unstable.

Files with missing lines Patch % Lines
src/valkey-cli.c 44.44% 5 Missing ⚠️
src/valkey-benchmark.c 57.14% 3 Missing ⚠️
src/cli_common.c 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2067      +/-   ##
============================================
- Coverage     71.07%   71.00%   -0.07%     
============================================
  Files           122      122              
  Lines         66159    66172      +13     
============================================
- Hits          47021    46986      -35     
- Misses        19138    19186      +48     
Files with missing lines Coverage Δ
src/cli_common.c 62.04% <50.00%> (-0.53%) ⬇️
src/valkey-benchmark.c 61.97% <57.14%> (-0.34%) ⬇️
src/valkey-cli.c 56.23% <44.44%> (-0.09%) ⬇️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zuiderkwast
zuiderkwast merged commit 0862f9f into valkey-io:unstable May 9, 2025
zuiderkwast pushed a commit to valkey-io/valkey-doc that referenced this pull request May 9, 2025
Docs for valkey-io/valkey#2067

Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
rainsupreme pushed a commit to rainsupreme/valkey that referenced this pull request May 14, 2025
Add '--mptcp' for both valkey-cli and valkey-benchmark to enable MPTCP.

Signed-off-by: zhenwei pi <zhenwei.pi@linux.dev>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
@pizhenwei
pizhenwei deleted the mptcp-cli branch May 14, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes This issue should get a line item in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants