Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mangle filenames when extracted from containers #53

Merged
merged 5 commits into from Jun 29, 2021

Conversation

akx
Copy link
Member

@akx akx commented Jun 14, 2021

Fixes #45

@akx akx added bug Something isn't working enhancement New feature or request labels Jun 14, 2021
@akx akx marked this pull request as ready for review June 14, 2021 08:39
@akx akx requested review from a team, ruksi and tokkoro and removed request for a team June 16, 2021 10:30
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

one potentially unnecessary block if you'd clarify 🔍

valohai/internals/vfs.py Outdated Show resolved Hide resolved
@ruksi
Copy link
Member

ruksi commented Jun 29, 2021

will merge as has been dangling, the requested changes have no functional effect anyway

@ruksi ruksi merged commit 91e840f into master Jun 29, 2021
@ruksi ruksi deleted the container-concrete-name branch June 29, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

valohai-utils vfs mangles paths with archived inputs
3 participants