Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pie chart not showing labels #420

Closed
alejandrolacasa opened this issue Sep 22, 2016 · 4 comments
Closed

Pie chart not showing labels #420

alejandrolacasa opened this issue Sep 22, 2016 · 4 comments

Comments

@alejandrolacasa
Copy link

I just updated to 1.3 and now my pie charts has undefined (literally) labels.

I rolled back to 1.2 and they work perfectly.
Puigcerber added a commit to Puigcerber/ng2-charts that referenced this issue Oct 8, 2016
@Puigcerber
Update chart labels
1ae41ee 
The update method introduced in valor-software#410 and merged in valor-software#414 removed the ability of updating chart labels dynamically.

Closes valor-software#420 valor-software#445
@Puigcerber Puigcerber mentioned this issue Oct 8, 2016
Merged
valorkin pushed a commit that referenced this issue Oct 10, 2016
@Puigcerber @valorkin
fix(labels): Update chart labels (#456)
7175c1e 
The update method introduced in #410 and merged in #414 removed the ability of updating chart labels dynamically.

Closes #420 #445
@alejandrolacasa
Copy link
Author

It works now for 1.4.0 nicely. Thanks!

@nraboy
Copy link

nraboy commented Oct 14, 2016

Does something else need to be done to make this work? When I define constant labels, they show up, but when I have dynamic labels created from API data, they show as undefined.

Any ideas?

@valorkin
Copy link
Member

Refresh Chart, I didn't saw a method to redraw labels separately

@nraboy
Copy link

nraboy commented Oct 15, 2016

I applied the changes from here manually:

7175c1e

I noticed that those changes were not in the 1.4.0 version. However once I added those changes it worked great.

My question now is, when will those changes appear in a versioned release?

valorkin pushed a commit that referenced this issue Dec 16, 2016
@Puigcerber @valorkin
fix(labels): Update chart labels (#456)
17038da 
The update method introduced in #410 and merged in #414 removed the ability of updating chart labels dynamically.

Closes #420 #445
@ChrisAllisonMalta ChrisAllisonMalta mentioned this issue Mar 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nraboy @valorkin @alejandrolacasa