Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug report] Missing @types/dragula from published module #876

Closed
1 of 5 tasks
juusee opened this issue Jul 20, 2018 · 5 comments
Closed
1 of 5 tasks

[bug report] Missing @types/dragula from published module #876

juusee opened this issue Jul 20, 2018 · 5 comments

Comments

@juusee
Copy link

juusee commented Jul 20, 2018

  • Build errors, incompatibility, errors that prevent using the library entirely
  • Incorrect behaviour with [dragulaModel]
  • Performance issue
  • Documentation/demo problem
  • Other

Describe the bug

When started using v2 got this error after compiling: ERROR in node_modules/ng2-dragula/dist/DrakeWithModels.d.ts(1,23): error TS2688: Cannot find type definition file for 'dragula'.

Versions

  • @angular/core: 6.0.9
  • ng2-dragula: 2.0.0
  • rxjs: 6.2.2
@cormacrelf
Copy link
Contributor

Instant fix might be to install “@types/dragula”. I might look into whether this should be a dependency.

@cormacrelf
Copy link
Contributor

cormacrelf commented Jul 20, 2018

Although maybe add a typeRoots entry in tsconfig for “node_modules/@types”?

@juusee
Copy link
Author

juusee commented Jul 20, 2018

Installing types for dragula worked, thanks

@juusee
Copy link
Author

juusee commented Jul 20, 2018

Already had typeRoots set

@cormacrelf
Copy link
Contributor

cormacrelf commented Jul 20, 2018

v2.0.1 released. You won't need to install @types/dragula, because it is a proper dependency now. You should remove it from your package.json.

@cormacrelf cormacrelf changed the title [bug report] ERROR in node_modules/ng2-dragula/dist/DrakeWithModels.d.ts(1,23): error TS2688: Cannot find type definition file for 'dragula'. [bug report] Missing @types/dragula from published module Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants