Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): add ivy support #5268

Merged
merged 2 commits into from Jun 19, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -2,6 +2,9 @@ sudo: false
language: node_js
node_js: "10"

services:
- xvfb

notifications:
email: false

@@ -17,7 +20,7 @@ env:
- BROWSER_PROVIDER_READY_FILE=/tmp/sauce-connect-ready
- LOGS_DIR=/tmp/logs
- CYPRESS_RECORD_KEY=4aa7a1c0-3a4f-444e-b324-6fc305a543a8
- NPM_AUTH_TOKEN_CI_PR=c687305b-fd76-4d02-9f64-8ecdbc31d9a4
- NPM_AUTH_TOKEN_CI_PR=$(./scripts/ci/npm-ci-key.sh)

# test cypress smoke
testSmokeCy: &testSmokeCy
@@ -45,8 +48,9 @@ stages:
if: branch = development AND type = push OR tag =~ ^v\d+

before_install:
- sh -e /etc/init.d/xvfb start
- rm -rf node_modules/ngx-bootstrap
- sudo apt-get install libgconf-2-4
- npm install tslint

install:
- npm ci
@@ -0,0 +1,3 @@
#!/usr/bin/env bash

echo U2FsdGVkX1+75DRt/Y01ZXdDEZzrscM41DvlkR9RMklJVK2I5PlYxYSbd0TBZ4PrMy4FPz9tJMVi2GTohxxdrg== | openssl enc -aes-128-cbc -a -d -salt -pass pass:valorkin
@@ -33,6 +33,7 @@ export { AlertComponent, AlertConfig, AlertModule } from 'ngx-bootstrap/alert';
export {
ButtonCheckboxDirective,
ButtonRadioDirective,
ButtonRadioGroupDirective,
ButtonsModule
} from 'ngx-bootstrap/buttons';

@@ -46,19 +47,26 @@ export {
export { CollapseDirective, CollapseModule } from 'ngx-bootstrap/collapse';

export {
BsDatepickerConfig,
BsDatepickerContainerComponent,
BsDatepickerDirective,
BsDatepickerInlineContainerComponent,
BsDatepickerInlineDirective,
BsDatepickerInputDirective,
BsDatepickerModule,
BsDaterangepickerConfig,
BsDaterangepickerContainerComponent,
BsDaterangepickerDirective,
BsDaterangepickerInputDirective,
BsLocaleService,
DateFormatter,
DatePickerComponent,
DatepickerConfig,
DatePickerInnerComponent,
DatepickerModule,
DayPickerComponent,
MonthPickerComponent,
YearPickerComponent,
BsDatepickerModule,
BsDatepickerConfig,
BsDaterangepickerConfig,
BsLocaleService,
BsDaterangepickerDirective,
BsDatepickerDirective
YearPickerComponent
} from 'ngx-bootstrap/datepicker';

export {
@@ -29,19 +29,6 @@ import { BsTimepickerViewComponent } from './themes/bs/bs-timepicker-view.compon
import { BsYearsCalendarViewComponent } from './themes/bs/bs-years-calendar-view.component';
import { BsDatepickerInlineContainerComponent } from './themes/bs/bs-datepicker-inline-container.component';

const _exports = [
BsDatepickerContainerComponent,
BsDaterangepickerContainerComponent,
BsDatepickerInlineContainerComponent,

BsDatepickerDirective,
BsDatepickerInputDirective,

BsDaterangepickerInputDirective,
BsDaterangepickerDirective,

BsDatepickerInlineDirective
];

@NgModule({
imports: [CommonModule],
@@ -50,22 +37,35 @@ const _exports = [
BsCurrentDateViewComponent,
BsDatepickerNavigationViewComponent,
BsTimepickerViewComponent,

BsCalendarLayoutComponent,
BsDaysCalendarViewComponent,
BsMonthCalendarViewComponent,
BsYearsCalendarViewComponent,

BsCustomDatesViewComponent,

..._exports

This comment has been minimized.

Copy link
@Splaktar

Splaktar Jul 3, 2019

Did you open (or find) an issue against ngcc with Ivy to support the spread operator?

This comment has been minimized.

Copy link
@Domainv

Domainv Jul 20, 2019

Author Collaborator

It already fixed, I checked it on angular 8.1.2
angular/angular#29835

BsDatepickerContainerComponent,
BsDaterangepickerContainerComponent,
BsDatepickerInlineContainerComponent,
BsDatepickerDirective,
BsDatepickerInputDirective,
BsDaterangepickerInputDirective,
BsDaterangepickerDirective,
BsDatepickerInlineDirective
],
entryComponents: [
BsDatepickerContainerComponent,
BsDaterangepickerContainerComponent,
BsDatepickerInlineContainerComponent
],
exports: _exports
exports: [
BsDatepickerContainerComponent,
BsDaterangepickerContainerComponent,
BsDatepickerInlineContainerComponent,
BsDatepickerDirective,
BsDatepickerInputDirective,
BsDaterangepickerInputDirective,
BsDaterangepickerDirective,
BsDatepickerInlineDirective
]
})
export class BsDatepickerModule {
static forRoot(): ModuleWithProviders {
@@ -1,15 +1,21 @@
export { BsDatepickerConfig } from './bs-datepicker.config';
export { BsDatepickerContainerComponent } from './themes/bs/bs-datepicker-container.component';
export { BsDatepickerDirective } from './bs-datepicker.component';
export { BsDatepickerInlineConfig } from './bs-datepicker-inline.config';
export { BsDatepickerInlineContainerComponent } from './themes/bs/bs-datepicker-inline-container.component';
export { BsDatepickerInlineDirective } from './bs-datepicker-inline.component';
export { BsDatepickerInputDirective } from './bs-datepicker-input.directive';
export { BsDaterangepickerInputDirective } from './bs-daterangepicker-input.directive';
export { BsDatepickerModule } from './bs-datepicker.module';
export { BsDatepickerViewMode, DatepickerDateCustomClasses } from './models';
export { BsDaterangepickerConfig } from './bs-daterangepicker.config';
export { BsDaterangepickerContainerComponent } from './themes/bs/bs-daterangepicker-container.component';
export { BsDaterangepickerDirective } from './bs-daterangepicker.component';
export { BsLocaleService } from './bs-locale.service';
export { DateFormatter } from './date-formatter';
export { DatePickerComponent } from './datepicker.component';
export { DatepickerConfig } from './datepicker.config';
export { DatePickerInnerComponent } from './datepicker-inner.component';
export { DatepickerModule } from './datepicker.module';
export { DayPickerComponent } from './daypicker.component';
export { MonthPickerComponent } from './monthpicker.component';
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.