From c97dd2ad0e2df55b6ea35436fd560c1efe8f6303 Mon Sep 17 00:00:00 2001 From: SvetlanaMuravlova Date: Fri, 17 Jun 2022 12:54:17 +0300 Subject: [PATCH 1/4] feat(links): updated links with opportunity to open link in next tabs --- .../components/popover/popover.component.html | 40 +++++----- .../services-block.component.html | 4 +- .../services-block.component.ts | 4 +- .../src/services/articlesRoute.service.ts | 22 ++++-- libs/portfolio/src/projectsRoute.service.ts | 11 ++- .../blog-portfolio/src/blog.component.html | 8 +- .../blog-portfolio/src/blog.component.ts | 4 +- .../src/general-page.component.html | 74 ++++++++++++------- .../src/genral-page.component.ts | 8 +- .../blog-portfolio/src/project.component.html | 23 +++--- .../blog-portfolio/src/project.component.ts | 4 +- .../src/projects-block.component.html | 8 +- .../src/projects-block.component.ts | 4 +- .../src/services/route.service.ts | 26 ++++--- .../home-page/src/main-page.component.html | 14 ++-- .../home-page/src/main-page.component.ts | 2 +- .../src/services-page.component.html | 2 +- 17 files changed, 159 insertions(+), 99 deletions(-) diff --git a/libs/common-docs/src/components/popover/popover.component.html b/libs/common-docs/src/components/popover/popover.component.html index 1024ba926..cd737c4c3 100644 --- a/libs/common-docs/src/components/popover/popover.component.html +++ b/libs/common-docs/src/components/popover/popover.component.html @@ -2,16 +2,18 @@
-
-
-
- -

{{item.title}}

+ +

{{item.description}}

@@ -23,16 +25,18 @@

{{item.title}}

-
-
-
- -

{{item.title}}

-
-
diff --git a/libs/common-docs/src/components/services_block/services-block.component.html b/libs/common-docs/src/components/services_block/services-block.component.html index 9f4894d3f..5423deeb8 100644 --- a/libs/common-docs/src/components/services_block/services-block.component.html +++ b/libs/common-docs/src/components/services_block/services-block.component.html @@ -1,8 +1,8 @@
Language
- + + + - + + +
diff --git a/libs/route-pages/blog-portfolio/src/blog.component.ts b/libs/route-pages/blog-portfolio/src/blog.component.ts index b201d60c5..b0a971213 100644 --- a/libs/route-pages/blog-portfolio/src/blog.component.ts +++ b/libs/route-pages/blog-portfolio/src/blog.component.ts @@ -100,8 +100,8 @@ export class BlogComponent implements OnDestroy { this.activeIndex = [lang]; } - route(title: string) { - this.routeArticle.route(title); + getRouteLink(link: string): any { + return this.routeArticle.getRouteLink(link); } checkLength(): boolean { diff --git a/libs/route-pages/blog-portfolio/src/general-page.component.html b/libs/route-pages/blog-portfolio/src/general-page.component.html index 436d941f1..21416d9f5 100644 --- a/libs/route-pages/blog-portfolio/src/general-page.component.html +++ b/libs/route-pages/blog-portfolio/src/general-page.component.html @@ -12,16 +12,23 @@

- - -

@@ -64,22 +76,28 @@

- + + + + + - + + + + + diff --git a/libs/route-pages/blog-portfolio/src/genral-page.component.ts b/libs/route-pages/blog-portfolio/src/genral-page.component.ts index bc45c4067..bdcefea13 100644 --- a/libs/route-pages/blog-portfolio/src/genral-page.component.ts +++ b/libs/route-pages/blog-portfolio/src/genral-page.component.ts @@ -81,12 +81,8 @@ export class GeneralPageComponent implements OnDestroy{ return value.slice(0,4); } - route(link?: string) { - if (!link) { - return; - } - - this.routeServ.route(link, this.isBlogPage()); + getRouteLink(link: string): any { + return this.routeServ.getRouteLink(link); } filterFirstItems() { diff --git a/libs/route-pages/blog-portfolio/src/project.component.html b/libs/route-pages/blog-portfolio/src/project.component.html index 107af5b93..5eb5c2ff6 100644 --- a/libs/route-pages/blog-portfolio/src/project.component.html +++ b/libs/route-pages/blog-portfolio/src/project.component.html @@ -130,17 +130,22 @@

Aspects

Next Project

-
- -
+ +
+ +
+
-
-

Website

- + + diff --git a/libs/route-pages/blog-portfolio/src/project.component.ts b/libs/route-pages/blog-portfolio/src/project.component.ts index 6e7073c82..cf52f32cd 100644 --- a/libs/route-pages/blog-portfolio/src/project.component.ts +++ b/libs/route-pages/blog-portfolio/src/project.component.ts @@ -84,8 +84,8 @@ export class ProjectComponent implements OnDestroy{ }); } - route(link: string) { - this.projectRoute.route(link, false); + getRouteLink(link: string): any { + return this.projectRoute.getRouteLink(link); } getRespSrc(link: string): string { diff --git a/libs/route-pages/blog-portfolio/src/projects-block.component.html b/libs/route-pages/blog-portfolio/src/projects-block.component.html index 82945e8bf..b267e2342 100644 --- a/libs/route-pages/blog-portfolio/src/projects-block.component.html +++ b/libs/route-pages/blog-portfolio/src/projects-block.component.html @@ -24,12 +24,16 @@
- + + + - + + +
diff --git a/libs/route-pages/blog-portfolio/src/projects-block.component.ts b/libs/route-pages/blog-portfolio/src/projects-block.component.ts index 7db1705bd..d70f163d6 100644 --- a/libs/route-pages/blog-portfolio/src/projects-block.component.ts +++ b/libs/route-pages/blog-portfolio/src/projects-block.component.ts @@ -75,8 +75,8 @@ export class ProjectsBlockComponent { return !!(this.sortProjects?.length && this.sortProjects?.length > 8); } - route(title: string) { - this.routeProjectServ.route(title, false); + getRouteLink(link: string): any { + return this.routeProjectServ.getRouteLink(link); } updateProjects(projects: IPortfolio[]) { diff --git a/libs/route-pages/blog-portfolio/src/services/route.service.ts b/libs/route-pages/blog-portfolio/src/services/route.service.ts index 7a9728f5e..394eeacf9 100644 --- a/libs/route-pages/blog-portfolio/src/services/route.service.ts +++ b/libs/route-pages/blog-portfolio/src/services/route.service.ts @@ -6,18 +6,26 @@ export class BlogPortfolioRouteService { constructor( private router: Router - ){} + ) {} route(title: string, isBlogPage: boolean) { + this.router.navigate([isBlogPage ? 'blog' : 'portfolio', this.getRefactoredLink(title)]); + } + + getRouteLink(title: string): string { + return this.getRefactoredLink(title); + } + + getRefactoredLink(title: string): string { let link = title; - while(link.match(' '|| ':' || '–' || '—' || '&')) { - link = link.replace(' ','_'); - link = link.replace(':',''); - link = link.replace('–','_'); - link = link.replace('—','_'); - link = link.replace('&','_'); + while (link.match(' ' || ':' || '–' || '—' || '&')) { + link = link.replace(' ', '_'); + link = link.replace(':', ''); + link = link.replace('–', '_'); + link = link.replace('—', '_'); + link = link.replace('&', '_'); } - this.router.navigate([isBlogPage ? 'blog' : 'portfolio', link]); + return link; } -} \ No newline at end of file +} diff --git a/libs/route-pages/home-page/src/main-page.component.html b/libs/route-pages/home-page/src/main-page.component.html index b7146fd4a..d618206ae 100644 --- a/libs/route-pages/home-page/src/main-page.component.html +++ b/libs/route-pages/home-page/src/main-page.component.html @@ -81,13 +81,15 @@

Technology

- -
-

{{project.name}}

- +
diff --git a/libs/route-pages/home-page/src/main-page.component.ts b/libs/route-pages/home-page/src/main-page.component.ts index 365d4d593..e2d2f8efc 100644 --- a/libs/route-pages/home-page/src/main-page.component.ts +++ b/libs/route-pages/home-page/src/main-page.component.ts @@ -332,7 +332,7 @@ export class MainPageComponent { } projectRoute(name: string) { - this.projectRouteServ.route(name); + this.projectRouteServ.getRouteLink(name); } checkIndex(index: number): boolean { diff --git a/libs/route-pages/services-page/src/services-page.component.html b/libs/route-pages/services-page/src/services-page.component.html index f8fdf55cc..31cef2e07 100644 --- a/libs/route-pages/services-page/src/services-page.component.html +++ b/libs/route-pages/services-page/src/services-page.component.html @@ -18,7 +18,7 @@

Services

-
+

Wondering what special offerings
can we provide?

Check out our exclusive packages!

From 4f82ca46f4c9333a6a565e2bdaa5e3b3e298be3b Mon Sep 17 00:00:00 2001 From: SvetlanaMuravlova Date: Fri, 17 Jun 2022 18:48:16 +0300 Subject: [PATCH 2/4] refactored same services, deleted extra module portfolio --- angular.json | 49 +------------------ .../valor-software-site/src/app/app.module.ts | 3 +- libs/common-docs/src/common-docs.module.ts | 13 +++-- .../blog-portfolio-item.component.ts | 2 +- .../blog-preview/blog-preview.component.html | 6 ++- .../blog-preview/blog-preview.component.ts | 8 +-- ...ervice.ts => blogArticlesRoute.service.ts} | 11 +---- .../src/services}/getPortfolio.service.ts | 4 +- libs/common-docs/src/services/seo.service.ts | 12 ++--- .../src/tokens}/portfolioList.token.ts | 0 libs/portfolio/.eslintrc.json | 46 ----------------- libs/portfolio/README.md | 9 ---- libs/portfolio/jest.config.js | 20 -------- libs/portfolio/ng-package.json | 7 --- libs/portfolio/package.json | 11 ----- libs/portfolio/src/index.ts | 3 -- libs/portfolio/src/portfolio.interface.ts | 25 ---------- libs/portfolio/src/portfolio.module.ts | 15 ------ libs/portfolio/src/projectsRoute.service.ts | 31 ------------ libs/portfolio/src/test-setup.ts | 1 - libs/portfolio/tsconfig.json | 24 --------- libs/portfolio/tsconfig.lib.json | 23 --------- libs/portfolio/tsconfig.lib.prod.json | 10 ---- libs/portfolio/tsconfig.spec.json | 14 ------ .../src/blog-portfolio.module.ts | 5 +- .../blog-portfolio/src/blog.component.ts | 5 +- .../src/directives/sort.directive.ts | 3 +- .../src/general-page.component.html | 12 ++++- .../src/genral-page.component.ts | 7 ++- .../blog-portfolio/src/project.component.html | 4 +- .../blog-portfolio/src/project.component.ts | 9 ++-- .../src/projects-block.component.ts | 5 +- .../src/services/route.service.ts | 31 ------------ .../home-page/src/main-page.component.html | 4 +- .../home-page/src/main-page.component.ts | 10 ++-- .../home-page/src/main-page.module.ts | 6 +-- tsconfig.base.json | 3 -- 37 files changed, 64 insertions(+), 387 deletions(-) rename libs/common-docs/src/services/{articlesRoute.service.ts => blogArticlesRoute.service.ts} (70%) rename libs/{portfolio/src => common-docs/src/services}/getPortfolio.service.ts (87%) rename libs/{portfolio/src => common-docs/src/tokens}/portfolioList.token.ts (100%) delete mode 100644 libs/portfolio/.eslintrc.json delete mode 100644 libs/portfolio/README.md delete mode 100644 libs/portfolio/jest.config.js delete mode 100644 libs/portfolio/ng-package.json delete mode 100644 libs/portfolio/package.json delete mode 100644 libs/portfolio/src/index.ts delete mode 100644 libs/portfolio/src/portfolio.interface.ts delete mode 100644 libs/portfolio/src/portfolio.module.ts delete mode 100644 libs/portfolio/src/projectsRoute.service.ts delete mode 100644 libs/portfolio/src/test-setup.ts delete mode 100644 libs/portfolio/tsconfig.json delete mode 100644 libs/portfolio/tsconfig.lib.json delete mode 100644 libs/portfolio/tsconfig.lib.prod.json delete mode 100644 libs/portfolio/tsconfig.spec.json delete mode 100644 libs/route-pages/blog-portfolio/src/services/route.service.ts diff --git a/angular.json b/angular.json index 0342ce83f..7d434c2e3 100644 --- a/angular.json +++ b/angular.json @@ -47,8 +47,7 @@ }, "tags": [], "implicitDependencies": [ - "file-uploader", - "portfolio" + "file-uploader" ] }, "feedback": { @@ -143,52 +142,6 @@ }, "tags": [] }, - "portfolio": { - "projectType": "library", - "root": "libs/portfolio", - "sourceRoot": "libs/portfolio/src", - "prefix": "valor-software-site-base", - "architect": { - "build": { - "builder": "@nrwl/angular:ng-packagr-lite", - "outputs": [ - "dist/libs/portfolio" - ], - "options": { - "project": "libs/portfolio/ng-package.json" - }, - "configurations": { - "production": { - "tsConfig": "libs/portfolio/tsconfig.lib.prod.json" - }, - "development": { - "tsConfig": "libs/portfolio/tsconfig.lib.json" - } - }, - "defaultConfiguration": "production" - }, - "test": { - "builder": "@nrwl/jest:jest", - "outputs": [ - "coverage/libs/portfolio" - ], - "options": { - "jestConfig": "libs/portfolio/jest.config.js", - "passWithNoTests": true - } - }, - "lint": { - "builder": "@nrwl/linter:eslint", - "options": { - "lintFilePatterns": [ - "libs/portfolio/src/**/*.ts", - "libs/portfolio/src/**/*.html" - ] - } - } - }, - "tags": [] - }, "route-pages-blog-portfolio": { "projectType": "library", "root": "libs/route-pages/blog-portfolio", diff --git a/apps/valor-software-site/src/app/app.module.ts b/apps/valor-software-site/src/app/app.module.ts index 687afd3c1..c89397160 100644 --- a/apps/valor-software-site/src/app/app.module.ts +++ b/apps/valor-software-site/src/app/app.module.ts @@ -3,11 +3,10 @@ import { BrowserModule } from '@angular/platform-browser'; import { RouterModule } from '@angular/router'; import { routes } from './app.routing'; import { AppComponent } from './app.component'; -import {CommonDocsModule, ARTICLES_LIST, SeoService} from '@valor-software/common-docs'; +import { CommonDocsModule, ARTICLES_LIST, SeoService, PORTFOLIO_LIST } from '@valor-software/common-docs'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; import { ScullyLibModule } from '@scullyio/ng-lib'; import { articlesList } from "../assets/blog/articles.list"; -import { PORTFOLIO_LIST } from "@valor-software/portfolio"; import { portfolioList } from "../assets/portfolio/portfolio.list"; import { NotFoundComponent } from './404.component'; diff --git a/libs/common-docs/src/common-docs.module.ts b/libs/common-docs/src/common-docs.module.ts index 5fde7d393..f328d8fed 100644 --- a/libs/common-docs/src/common-docs.module.ts +++ b/libs/common-docs/src/common-docs.module.ts @@ -19,9 +19,9 @@ import { SwiperModule } from "swiper/angular"; import { BlogPreviewComponent } from './components/blog-preview/blog-preview.component'; import { BlogPortfolioItemComponent } from './components/blog-preview/blog-portfolio-item.component'; import { GetArticlesService } from './services/getArticles.service'; -import { ArticlesRouteService } from './services/articlesRoute.service'; +import { BlogArticlesRouteService } from './services/blogArticlesRoute.service'; import { RECAPTCHA_V3_SITE_KEY, RecaptchaV3Module } from 'ng-recaptcha'; -import { GetPortfolioService } from "@valor-software/portfolio"; +import { GetPortfolioService } from "./services/getPortfolio.service"; import { CustomSlicePipe } from './pipes/customSlice.pipe'; export { PopoverComponent } from './components/popover/popover.component'; @@ -34,13 +34,16 @@ export { ModalService } from './services/modal.service'; export { BreadCrumbsComponent } from './components/breadCrumbs/breadCrumbs.component'; export { ShowHideDirective } from './directives/showHide.directive'; export { GetArticlesService } from './services/getArticles.service'; -export { ArticlesRouteService } from './services/articlesRoute.service'; +export { BlogArticlesRouteService } from './services/blogArticlesRoute.service'; export { IArticle } from './models/article.interface'; export { BlogPreviewComponent } from './components/blog-preview/blog-preview.component'; export { BlogPortfolioItemComponent } from './components/blog-preview/blog-portfolio-item.component'; export { ARTICLES_LIST } from './tokens/articlesList.token'; export { SeoService } from './services/seo.service'; export { CustomSlicePipe } from './pipes/customSlice.pipe'; +export { PORTFOLIO_LIST } from './tokens/portfolioList.token'; +export { IPortfolio } from './models/portfolio.interface'; +export { GetPortfolioService } from './services/getPortfolio.service'; @NgModule({ declarations: [ @@ -68,9 +71,9 @@ export { CustomSlicePipe } from './pipes/customSlice.pipe'; ShowHideDirective, BlogPreviewComponent, BlogPortfolioItemComponent, - CustomSlicePipe + CustomSlicePipe, ], - providers: [ModalService, SendEmailService, ArticlesRouteService, GetArticlesService, GetPortfolioService, + providers: [ModalService, SendEmailService, BlogArticlesRouteService, GetArticlesService, GetPortfolioService, { provide: RECAPTCHA_V3_SITE_KEY, useValue: '6LctnKQdAAAAABGStzrEdBnCWVYwkqAafI7pcUz3', diff --git a/libs/common-docs/src/components/blog-preview/blog-portfolio-item.component.ts b/libs/common-docs/src/components/blog-preview/blog-portfolio-item.component.ts index 88b8fc60c..a45e77206 100644 --- a/libs/common-docs/src/components/blog-preview/blog-portfolio-item.component.ts +++ b/libs/common-docs/src/components/blog-preview/blog-portfolio-item.component.ts @@ -1,6 +1,6 @@ import { Component, Input } from '@angular/core'; import { IArticle } from "../../models/article.interface"; -import { IPortfolio } from "@valor-software/portfolio"; +import { IPortfolio } from "../../models/portfolio.interface"; @Component({ diff --git a/libs/common-docs/src/components/blog-preview/blog-preview.component.html b/libs/common-docs/src/components/blog-preview/blog-preview.component.html index c6deb7e51..5e6085ccc 100644 --- a/libs/common-docs/src/components/blog-preview/blog-preview.component.html +++ b/libs/common-docs/src/components/blog-preview/blog-preview.component.html @@ -4,7 +4,11 @@ class="article_swiper" > - + + + + + \ No newline at end of file diff --git a/libs/common-docs/src/components/blog-preview/blog-preview.component.ts b/libs/common-docs/src/components/blog-preview/blog-preview.component.ts index 4c6df250d..103a74137 100644 --- a/libs/common-docs/src/components/blog-preview/blog-preview.component.ts +++ b/libs/common-docs/src/components/blog-preview/blog-preview.component.ts @@ -2,7 +2,7 @@ import {Component, OnDestroy, Input, OnInit} from '@angular/core'; import { GetArticlesService } from "../../services/getArticles.service"; import { IArticle } from "../../models/article.interface"; import { forkJoin, Subscription } from "rxjs"; -import { ArticlesRouteService } from "../../services/articlesRoute.service"; +import { BlogArticlesRouteService } from "../../services/blogArticlesRoute.service"; import SwiperCore, { Pagination, SwiperOptions } from "swiper"; SwiperCore.use([Pagination]); @@ -37,7 +37,7 @@ export class BlogPreviewComponent implements OnDestroy, OnInit{ constructor( private getArticles: GetArticlesService, - private articleRoute: ArticlesRouteService + private articleRoute: BlogArticlesRouteService ) {} ngOnInit() { @@ -58,7 +58,7 @@ export class BlogPreviewComponent implements OnDestroy, OnInit{ this.$articles?.unsubscribe(); } - route(title: string) { - this.articleRoute.route(title); + getRouteLink(link: string): string { + return this.articleRoute.getRouteLink(link); } } \ No newline at end of file diff --git a/libs/common-docs/src/services/articlesRoute.service.ts b/libs/common-docs/src/services/blogArticlesRoute.service.ts similarity index 70% rename from libs/common-docs/src/services/articlesRoute.service.ts rename to libs/common-docs/src/services/blogArticlesRoute.service.ts index b2ca90ff3..e82864390 100644 --- a/libs/common-docs/src/services/articlesRoute.service.ts +++ b/libs/common-docs/src/services/blogArticlesRoute.service.ts @@ -1,16 +1,7 @@ import { Injectable } from '@angular/core'; -import { Router } from "@angular/router"; @Injectable({providedIn: 'platform'}) -export class ArticlesRouteService { - - constructor( - private router: Router - ){} - - route(title: string) { - this.router.navigate(['blog', this.getRefactoredLink(title)]); - } +export class BlogArticlesRouteService { getRouteLink(title: string): string { return this.getRefactoredLink(title); diff --git a/libs/portfolio/src/getPortfolio.service.ts b/libs/common-docs/src/services/getPortfolio.service.ts similarity index 87% rename from libs/portfolio/src/getPortfolio.service.ts rename to libs/common-docs/src/services/getPortfolio.service.ts index a80c6c034..079d51324 100644 --- a/libs/portfolio/src/getPortfolio.service.ts +++ b/libs/common-docs/src/services/getPortfolio.service.ts @@ -1,8 +1,8 @@ import { Inject, Injectable } from '@angular/core'; import { HttpClient } from '@angular/common/http'; import { Observable } from 'rxjs'; -import { IPortfolio } from "./portfolio.interface"; -import { PORTFOLIO_LIST } from "./portfolioList.token"; +import { IPortfolio } from "../models/portfolio.interface"; +import { PORTFOLIO_LIST } from "../tokens/portfolioList.token"; @Injectable({providedIn: 'platform'}) diff --git a/libs/common-docs/src/services/seo.service.ts b/libs/common-docs/src/services/seo.service.ts index 3a2986622..bc89cde84 100644 --- a/libs/common-docs/src/services/seo.service.ts +++ b/libs/common-docs/src/services/seo.service.ts @@ -1,10 +1,10 @@ -import { Injectable, Inject } from '@angular/core'; +import { Injectable } from '@angular/core'; import { Title, Meta } from '@angular/platform-browser'; -import {filter} from "rxjs/operators"; -import {NavigationEnd, Router, UrlSegment} from "@angular/router"; -import {Observable, Subscription} from "rxjs"; -import {GetArticlesService} from "./getArticles.service"; -import { GetPortfolioService } from "@valor-software/portfolio"; +import { filter } from "rxjs/operators"; +import { NavigationEnd, Router, UrlSegment } from "@angular/router"; +import { Observable, Subscription } from "rxjs"; +import { GetArticlesService } from "./getArticles.service"; +import { GetPortfolioService } from "./getPortfolio.service"; const ex: {[key: string] : { nameType: 'meta' | 'title', name: string, nameValue: string, content: string }[]} = { '/': [ diff --git a/libs/portfolio/src/portfolioList.token.ts b/libs/common-docs/src/tokens/portfolioList.token.ts similarity index 100% rename from libs/portfolio/src/portfolioList.token.ts rename to libs/common-docs/src/tokens/portfolioList.token.ts diff --git a/libs/portfolio/.eslintrc.json b/libs/portfolio/.eslintrc.json deleted file mode 100644 index 17d600b7e..000000000 --- a/libs/portfolio/.eslintrc.json +++ /dev/null @@ -1,46 +0,0 @@ -{ - "extends": [ - "../../.eslintrc.json" - ], - "ignorePatterns": [ - "!**/*" - ], - "overrides": [ - { - "files": [ - "*.ts" - ], - "extends": [ - "plugin:@nrwl/nx/angular", - "plugin:@angular-eslint/template/process-inline-templates" - ], - "rules": { - "@angular-eslint/directive-selector": [ - "error", - { - "type": "attribute", - "prefix": "valorSoftwareSiteBase", - "style": "camelCase" - } - ], - "@angular-eslint/component-selector": [ - "error", - { - "type": "element", - "prefix": "valor-software-site-base", - "style": "kebab-case" - } - ] - } - }, - { - "files": [ - "*.html" - ], - "extends": [ - "plugin:@nrwl/nx/angular-template" - ], - "rules": {} - } - ] -} diff --git a/libs/portfolio/README.md b/libs/portfolio/README.md deleted file mode 100644 index 7ad895bb4..000000000 --- a/libs/portfolio/README.md +++ /dev/null @@ -1,9 +0,0 @@ -# portfolio - -This library was generated with [Nx](https://nx.dev). - - -## Running unit tests - -Run `nx test portfolio` to execute the unit tests. - diff --git a/libs/portfolio/jest.config.js b/libs/portfolio/jest.config.js deleted file mode 100644 index 127dea1ee..000000000 --- a/libs/portfolio/jest.config.js +++ /dev/null @@ -1,20 +0,0 @@ -module.exports = { - displayName: 'portfolio', - preset: '../../jest.preset.js', - setupFilesAfterEnv: ['/src/test-setup.ts'], - globals: { - 'ts-jest': { - tsconfig: '/tsconfig.spec.json', - stringifyContentPathRegex: '\\.(html|svg)$', - } - }, - coverageDirectory: '../../coverage/libs/portfolio', - transform: { - '^.+\\.(ts|js|html)$': 'jest-preset-angular' - }, - snapshotSerializers: [ - 'jest-preset-angular/build/serializers/no-ng-attributes', - 'jest-preset-angular/build/serializers/ng-snapshot', - 'jest-preset-angular/build/serializers/html-comment', - ] -}; diff --git a/libs/portfolio/ng-package.json b/libs/portfolio/ng-package.json deleted file mode 100644 index 356e5da05..000000000 --- a/libs/portfolio/ng-package.json +++ /dev/null @@ -1,7 +0,0 @@ -{ - "$schema": "../../node_modules/ng-packagr/ng-package.schema.json", - "dest": "../../dist/libs/portfolio", - "lib": { - "entryFile": "src/index.ts" - } -} diff --git a/libs/portfolio/package.json b/libs/portfolio/package.json deleted file mode 100644 index ab892ee3a..000000000 --- a/libs/portfolio/package.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "name": "@valor-software/portfolio", - "version": "0.0.1", - "peerDependencies": { - "@angular/common": "^12.2.0", - "@angular/core": "^12.2.0" - }, - "dependencies": { - "tslib": "^2.3.0" - } -} diff --git a/libs/portfolio/src/index.ts b/libs/portfolio/src/index.ts deleted file mode 100644 index a6ed102b0..000000000 --- a/libs/portfolio/src/index.ts +++ /dev/null @@ -1,3 +0,0 @@ - - export * from './portfolio.module'; - \ No newline at end of file diff --git a/libs/portfolio/src/portfolio.interface.ts b/libs/portfolio/src/portfolio.interface.ts deleted file mode 100644 index 51526d609..000000000 --- a/libs/portfolio/src/portfolio.interface.ts +++ /dev/null @@ -1,25 +0,0 @@ -export interface IPortfolio { - name: string; - link?: string; - behanceLink?: string; - goalsImg?: string; - solutionsImg?: string; - webSort?: string[]; - video?:string; - iframe?: string; - feedback?: string; - sortTechnologies: string[]; - previewImg: string; - description: string; - goals: string[]; - solutions: string[]; - outcome: string; - headerImg: string; - sortServices: string[]; - aspects: { - type: string[]; - country: string[]; - technology_stack: string[]; - services_provided: string[]; - } -} \ No newline at end of file diff --git a/libs/portfolio/src/portfolio.module.ts b/libs/portfolio/src/portfolio.module.ts deleted file mode 100644 index d69aba435..000000000 --- a/libs/portfolio/src/portfolio.module.ts +++ /dev/null @@ -1,15 +0,0 @@ -import { NgModule } from '@angular/core'; -import { CommonModule } from '@angular/common'; - -export { IPortfolio} from './portfolio.interface'; -export { GetPortfolioService } from './getPortfolio.service'; -export { ProjectsRouteService } from './projectsRoute.service'; -export { PORTFOLIO_LIST } from './portfolioList.token'; - -@NgModule({ - imports: [ - CommonModule - ] -}) -export class PortfolioModule { } - \ No newline at end of file diff --git a/libs/portfolio/src/projectsRoute.service.ts b/libs/portfolio/src/projectsRoute.service.ts deleted file mode 100644 index 35c26d2e1..000000000 --- a/libs/portfolio/src/projectsRoute.service.ts +++ /dev/null @@ -1,31 +0,0 @@ -import { Injectable } from '@angular/core'; -import { Router } from "@angular/router"; - -@Injectable({providedIn: 'platform'}) -export class ProjectsRouteService { - - constructor( - private router: Router - ){} - - route(title: string) { - this.router.navigate(['portfolio', this.getRefactoredLink(title)]); - } - - getRouteLink(title: string): string { - return this.getRefactoredLink(title); - } - - getRefactoredLink(title: string): string { - let link = title; - while(link.match(' '|| ':' || '–' || '—' || '&')) { - link = link.replace(' ','_'); - link = link.replace(':',''); - link = link.replace('–','_'); - link = link.replace('—','_'); - link = link.replace('&','_'); - } - - return link; - } -} diff --git a/libs/portfolio/src/test-setup.ts b/libs/portfolio/src/test-setup.ts deleted file mode 100644 index 1100b3e8a..000000000 --- a/libs/portfolio/src/test-setup.ts +++ /dev/null @@ -1 +0,0 @@ -import 'jest-preset-angular/setup-jest'; diff --git a/libs/portfolio/tsconfig.json b/libs/portfolio/tsconfig.json deleted file mode 100644 index d7a0c7629..000000000 --- a/libs/portfolio/tsconfig.json +++ /dev/null @@ -1,24 +0,0 @@ -{ - "extends": "../../tsconfig.base.json", - "files": [], - "include": [], - "references": [ - { - "path": "./tsconfig.lib.json" - }, - { - "path": "./tsconfig.spec.json" - } - ], - "compilerOptions": { - "forceConsistentCasingInFileNames": true, - "strict": true, - "noImplicitReturns": true, - "noFallthroughCasesInSwitch": true - }, - "angularCompilerOptions": { - "strictInjectionParameters": true, - "strictInputAccessModifiers": true, - "strictTemplates": true - } -} diff --git a/libs/portfolio/tsconfig.lib.json b/libs/portfolio/tsconfig.lib.json deleted file mode 100644 index fd887c2a4..000000000 --- a/libs/portfolio/tsconfig.lib.json +++ /dev/null @@ -1,23 +0,0 @@ -{ - "extends": "./tsconfig.json", - "compilerOptions": { - "outDir": "../../dist/out-tsc", - "target": "es2015", - "declaration": true, - "declarationMap": true, - "inlineSources": true, - "types": [], - "lib": [ - "dom", - "es2018" - ] - }, - "exclude": [ - "src/test-setup.ts", - "**/*.spec.ts", - "**/*.test.ts" - ], - "include": [ - "**/*.ts" - ] -} diff --git a/libs/portfolio/tsconfig.lib.prod.json b/libs/portfolio/tsconfig.lib.prod.json deleted file mode 100644 index 06de549e1..000000000 --- a/libs/portfolio/tsconfig.lib.prod.json +++ /dev/null @@ -1,10 +0,0 @@ -/* To learn more about this file see: https://angular.io/config/tsconfig. */ -{ - "extends": "./tsconfig.lib.json", - "compilerOptions": { - "declarationMap": false - }, - "angularCompilerOptions": { - "compilationMode": "partial" - } -} diff --git a/libs/portfolio/tsconfig.spec.json b/libs/portfolio/tsconfig.spec.json deleted file mode 100644 index a66ee4d3a..000000000 --- a/libs/portfolio/tsconfig.spec.json +++ /dev/null @@ -1,14 +0,0 @@ -{ - "extends": "./tsconfig.json", - "compilerOptions": { - "outDir": "../../dist/out-tsc", - "module": "commonjs", - "types": ["jest", "node"] - }, - "files": ["src/test-setup.ts"], - "include": [ - "**/*.test.ts", - "**/*.spec.ts", - "**/*.d.ts" -] -} diff --git a/libs/route-pages/blog-portfolio/src/blog-portfolio.module.ts b/libs/route-pages/blog-portfolio/src/blog-portfolio.module.ts index a5a15a974..96997e8a7 100644 --- a/libs/route-pages/blog-portfolio/src/blog-portfolio.module.ts +++ b/libs/route-pages/blog-portfolio/src/blog-portfolio.module.ts @@ -3,8 +3,7 @@ import { CommonModule } from '@angular/common'; import { RouterModule } from "@angular/router"; import { routes } from './routes'; import { GeneralPageComponent } from "./genral-page.component"; -import { CommonDocsModule } from "@valor-software/common-docs"; -import { BlogPortfolioRouteService } from "./services/route.service"; +import { CommonDocsModule, BlogArticlesRouteService } from "@valor-software/common-docs"; import { BlogComponent } from "./blog.component"; import { ProjectsBlockComponent } from "./projects-block.component"; import { SortDirective } from './directives/sort.directive'; @@ -31,7 +30,7 @@ import { SwiperModule } from "swiper/angular"; FeedbackModule, SwiperModule ], - providers: [ BlogPortfolioRouteService ] + providers: [ BlogArticlesRouteService ] }) export class BlogPortfolioModule { } \ No newline at end of file diff --git a/libs/route-pages/blog-portfolio/src/blog.component.ts b/libs/route-pages/blog-portfolio/src/blog.component.ts index b0a971213..2607c2d32 100644 --- a/libs/route-pages/blog-portfolio/src/blog.component.ts +++ b/libs/route-pages/blog-portfolio/src/blog.component.ts @@ -1,9 +1,8 @@ import {ChangeDetectorRef, Component, Input, OnDestroy} from '@angular/core'; import { GetArticlesService } from "@valor-software/common-docs"; import { Subscription } from "rxjs"; -import { IArticle } from "@valor-software/common-docs"; +import { IArticle, BlogArticlesRouteService } from "@valor-software/common-docs"; import { Router } from "@angular/router"; -import {ArticlesRouteService} from "@valor-software/common-docs"; export const Domains = { business_analysis: 'Business Analysis', @@ -44,7 +43,7 @@ export class BlogComponent implements OnDestroy { private router: Router, private getArticles: GetArticlesService, private cdr: ChangeDetectorRef, - private routeArticle: ArticlesRouteService + private routeArticle: BlogArticlesRouteService ) { this.getSortKeys(); } diff --git a/libs/route-pages/blog-portfolio/src/directives/sort.directive.ts b/libs/route-pages/blog-portfolio/src/directives/sort.directive.ts index 434790be0..cf61dfa66 100644 --- a/libs/route-pages/blog-portfolio/src/directives/sort.directive.ts +++ b/libs/route-pages/blog-portfolio/src/directives/sort.directive.ts @@ -3,8 +3,7 @@ import { Output, EventEmitter, Input } from "@angular/core"; -import { IPortfolio } from "@valor-software/portfolio"; -import { IArticle } from "@valor-software/common-docs"; +import { IArticle, IPortfolio } from "@valor-software/common-docs"; @Directive({ diff --git a/libs/route-pages/blog-portfolio/src/general-page.component.html b/libs/route-pages/blog-portfolio/src/general-page.component.html index 21416d9f5..ebf49d0c4 100644 --- a/libs/route-pages/blog-portfolio/src/general-page.component.html +++ b/libs/route-pages/blog-portfolio/src/general-page.component.html @@ -32,10 +32,18 @@

- + + + + + - + + + + +

diff --git a/libs/route-pages/blog-portfolio/src/genral-page.component.ts b/libs/route-pages/blog-portfolio/src/genral-page.component.ts index bdcefea13..179280bc5 100644 --- a/libs/route-pages/blog-portfolio/src/genral-page.component.ts +++ b/libs/route-pages/blog-portfolio/src/genral-page.component.ts @@ -2,9 +2,8 @@ import { Component, OnDestroy, Type } from '@angular/core'; import { NavigationEnd, Router } from "@angular/router"; import { filter } from "rxjs/operators"; import { forkJoin, Subscription } from "rxjs"; -import { GetArticlesService, IArticle } from "@valor-software/common-docs"; -import { GetPortfolioService, IPortfolio } from "@valor-software/portfolio"; -import { BlogPortfolioRouteService } from "./services/route.service"; +import { GetArticlesService, IArticle, GetPortfolioService, IPortfolio } from "@valor-software/common-docs"; +import { BlogArticlesRouteService } from "@valor-software/common-docs"; import SwiperCore, { Pagination, SwiperOptions } from "swiper"; SwiperCore.use([Pagination]); @@ -42,7 +41,7 @@ export class GeneralPageComponent implements OnDestroy{ private router: Router, private getArticlesServ: GetArticlesService, private getPortfolio: GetPortfolioService, - private routeServ: BlogPortfolioRouteService + private routeServ: BlogArticlesRouteService ) { this.router.events .pipe( diff --git a/libs/route-pages/blog-portfolio/src/project.component.html b/libs/route-pages/blog-portfolio/src/project.component.html index 5eb5c2ff6..f4f712a5a 100644 --- a/libs/route-pages/blog-portfolio/src/project.component.html +++ b/libs/route-pages/blog-portfolio/src/project.component.html @@ -130,13 +130,13 @@

Aspects

Next Project

- +
- +

Website

diff --git a/libs/route-pages/blog-portfolio/src/project.component.ts b/libs/route-pages/blog-portfolio/src/project.component.ts index cf52f32cd..b27c943d3 100644 --- a/libs/route-pages/blog-portfolio/src/project.component.ts +++ b/libs/route-pages/blog-portfolio/src/project.component.ts @@ -1,10 +1,9 @@ -import {ChangeDetectorRef, Component, OnDestroy} from '@angular/core'; -import { IPortfolio, GetPortfolioService } from "@valor-software/portfolio"; +import { ChangeDetectorRef, Component, OnDestroy } from '@angular/core'; import { Subscription } from "rxjs"; import { NavigationEnd, Router } from "@angular/router"; import { filter } from "rxjs/operators"; import { DomSanitizer } from '@angular/platform-browser'; -import { BlogPortfolioRouteService } from "./services/route.service"; +import { BlogArticlesRouteService, IPortfolio, GetPortfolioService } from "@valor-software/common-docs"; @Component({ // eslint-disable-next-line @angular-eslint/component-selector @@ -21,7 +20,7 @@ export class ProjectComponent implements OnDestroy{ private router: Router, private getProjectsServ: GetPortfolioService, private sanitizer: DomSanitizer, - private projectRoute: BlogPortfolioRouteService, + private projectRoute: BlogArticlesRouteService, private cdr: ChangeDetectorRef, ) { @@ -84,7 +83,7 @@ export class ProjectComponent implements OnDestroy{ }); } - getRouteLink(link: string): any { + getRouteLink(link: string): string { return this.projectRoute.getRouteLink(link); } diff --git a/libs/route-pages/blog-portfolio/src/projects-block.component.ts b/libs/route-pages/blog-portfolio/src/projects-block.component.ts index d70f163d6..46f98fb69 100644 --- a/libs/route-pages/blog-portfolio/src/projects-block.component.ts +++ b/libs/route-pages/blog-portfolio/src/projects-block.component.ts @@ -1,7 +1,6 @@ import {ChangeDetectorRef, Component, Input } from '@angular/core'; -import { IPortfolio } from "@valor-software/portfolio"; import { Router } from "@angular/router"; -import { BlogPortfolioRouteService } from './services/route.service'; +import { BlogArticlesRouteService, IPortfolio } from '@valor-software/common-docs'; const SortList = { all_projects: 'All Projects', @@ -32,7 +31,7 @@ export class ProjectsBlockComponent { constructor( private router: Router, private cdr: ChangeDetectorRef, - private routeProjectServ: BlogPortfolioRouteService + private routeProjectServ: BlogArticlesRouteService ) { this.getSortKeys(); } diff --git a/libs/route-pages/blog-portfolio/src/services/route.service.ts b/libs/route-pages/blog-portfolio/src/services/route.service.ts deleted file mode 100644 index 394eeacf9..000000000 --- a/libs/route-pages/blog-portfolio/src/services/route.service.ts +++ /dev/null @@ -1,31 +0,0 @@ -import { Injectable } from '@angular/core'; -import { Router } from "@angular/router"; - -@Injectable({providedIn: 'platform'}) -export class BlogPortfolioRouteService { - - constructor( - private router: Router - ) {} - - route(title: string, isBlogPage: boolean) { - this.router.navigate([isBlogPage ? 'blog' : 'portfolio', this.getRefactoredLink(title)]); - } - - getRouteLink(title: string): string { - return this.getRefactoredLink(title); - } - - getRefactoredLink(title: string): string { - let link = title; - while (link.match(' ' || ':' || '–' || '—' || '&')) { - link = link.replace(' ', '_'); - link = link.replace(':', ''); - link = link.replace('–', '_'); - link = link.replace('—', '_'); - link = link.replace('&', '_'); - } - - return link; - } -} diff --git a/libs/route-pages/home-page/src/main-page.component.html b/libs/route-pages/home-page/src/main-page.component.html index d618206ae..d37c082ed 100644 --- a/libs/route-pages/home-page/src/main-page.component.html +++ b/libs/route-pages/home-page/src/main-page.component.html @@ -80,8 +80,8 @@

Technology

-
- +
+

{{project.name}}

diff --git a/libs/route-pages/home-page/src/main-page.component.ts b/libs/route-pages/home-page/src/main-page.component.ts index e2d2f8efc..5ad8fd410 100644 --- a/libs/route-pages/home-page/src/main-page.component.ts +++ b/libs/route-pages/home-page/src/main-page.component.ts @@ -2,8 +2,8 @@ import {Component, ViewChild, ChangeDetectorRef, HostListener} from '@angular/co import { Router } from '@angular/router'; import { NpmStatisticService } from "./getNpmStatistic.service"; import SwiperCore, { Pagination, Mousewheel, SwiperOptions } from "swiper"; -import {forkJoin, Subscription} from "rxjs"; -import {GetPortfolioService, IPortfolio, ProjectsRouteService} from "@valor-software/portfolio"; +import { forkJoin, Subscription } from "rxjs"; +import { GetPortfolioService, IPortfolio, BlogArticlesRouteService } from "@valor-software/common-docs"; SwiperCore.use([Mousewheel, Pagination]); const slideModel = [ @@ -279,7 +279,7 @@ export class MainPageComponent { private cdr: ChangeDetectorRef, protected router: Router, private getPortfolio: GetPortfolioService, - private projectRouteServ: ProjectsRouteService + private projectRouteServ: BlogArticlesRouteService ) { this.$portfolio = forkJoin(this.getPortfolio.getFullListOfPortfolio()).subscribe((res: IPortfolio[] | undefined) => { this.projects = res; @@ -331,8 +331,8 @@ export class MainPageComponent { } } - projectRoute(name: string) { - this.projectRouteServ.getRouteLink(name); + projectRoute(name: string): string { + return this.projectRouteServ.getRouteLink(name); } checkIndex(index: number): boolean { diff --git a/libs/route-pages/home-page/src/main-page.module.ts b/libs/route-pages/home-page/src/main-page.module.ts index 12bcdabe1..9aa1502c9 100644 --- a/libs/route-pages/home-page/src/main-page.module.ts +++ b/libs/route-pages/home-page/src/main-page.module.ts @@ -3,12 +3,10 @@ import { CommonModule } from '@angular/common'; import { RouterModule, Routes } from "@angular/router"; import { routes } from "./routes"; import { SwiperModule } from "swiper/angular"; -import { CommonDocsModule } from '@valor-software/common-docs'; +import { CommonDocsModule, GetPortfolioService, BlogArticlesRouteService } from '@valor-software/common-docs'; import { NpmStatisticService } from './getNpmStatistic.service'; import { MainPageComponent } from "./main-page.component"; import { FeedbackModule } from "@valor-software/feedback"; -import {GetPortfolioService, ProjectsRouteService} from "@valor-software/portfolio"; - export { MainPageComponent } from "./main-page.component"; @@ -23,7 +21,7 @@ export { MainPageComponent } from "./main-page.component"; CommonDocsModule, FeedbackModule ], - providers: [NpmStatisticService, GetPortfolioService, ProjectsRouteService] + providers: [NpmStatisticService, GetPortfolioService, BlogArticlesRouteService] }) export class MainPageModule { static routes: Routes = routes; diff --git a/tsconfig.base.json b/tsconfig.base.json index bc9467cc6..b25fda703 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -39,9 +39,6 @@ "@valor-software/home-page": [ "libs/route-pages/home-page/src/index.ts" ], - "@valor-software/portfolio": [ - "libs/portfolio/src/index.ts" - ], "@valor-software/services-page": [ "libs/route-pages/services-page/src/index.ts" ], From d5f0b2117dae0a75d725c0180cbbf99b1535a8e6 Mon Sep 17 00:00:00 2001 From: SvetlanaMuravlova Date: Mon, 20 Jun 2022 13:42:33 +0300 Subject: [PATCH 3/4] fixed buttons with links, fixed breadcrumbs --- .../src/app/404.component.ts | 4 +- .../breadCrumbs/breadCrumbs.component.ts | 42 +++++++++++++------ .../src/general-page.component.html | 8 ++-- .../blog-portfolio/src/project.component.html | 8 ++-- .../careers/src/careers-page.component.html | 8 ++-- .../src/enterprises.component.html | 4 +- .../for-clients/src/nonProfit.component.html | 4 +- .../src/smallMediumBusinesses.component.html | 4 +- .../for-clients/src/startups.component.html | 4 +- .../home-page/src/main-page.component.html | 12 +++--- .../src/services-page.component.html | 4 +- 11 files changed, 60 insertions(+), 42 deletions(-) diff --git a/apps/valor-software-site/src/app/404.component.ts b/apps/valor-software-site/src/app/404.component.ts index bb6a4fc60..856753a1e 100644 --- a/apps/valor-software-site/src/app/404.component.ts +++ b/apps/valor-software-site/src/app/404.component.ts @@ -10,8 +10,8 @@ import { Component } from '@angular/core';

404

Ooops! You weren’t supposed to see this.

The page you’re looking for no longer exist. Return to the previous page and remember: you haven’t seen anything!

-
diff --git a/libs/route-pages/careers/src/careers-page.component.html b/libs/route-pages/careers/src/careers-page.component.html index e4d6b03ab..fc5f78d10 100644 --- a/libs/route-pages/careers/src/careers-page.component.html +++ b/libs/route-pages/careers/src/careers-page.component.html @@ -3,8 +3,8 @@

Who we are

Professional and friendly with our clients and co-workers, we treat each other as we would want to be treated. Our working environment emphasizes equality, transparency... and a pet-friendly atmosphere! That's what Valor is all about :)

-
-
diff --git a/libs/route-pages/for-clients/src/enterprises.component.html b/libs/route-pages/for-clients/src/enterprises.component.html index d2542ab95..f36bee140 100644 --- a/libs/route-pages/for-clients/src/enterprises.component.html +++ b/libs/route-pages/for-clients/src/enterprises.component.html @@ -7,8 +7,8 @@

Accelerating your enterprise technologies

We blend a business-oriented approach with deep technical expertise to help you solve the toughest challenges within your enterprise in a snap of fingers. It doesn’t matter if it’s cloud migration, optimization, implementation of new technologies, or underpinning everything with security — our industry competence will help you on this journey.

-
@@ -125,7 +125,7 @@

{{item}}

- +
@@ -165,7 +165,7 @@

{{slide.downloads | number}}

- +
diff --git a/libs/route-pages/services-page/src/services-page.component.html b/libs/route-pages/services-page/src/services-page.component.html index 31cef2e07..f6549c445 100644 --- a/libs/route-pages/services-page/src/services-page.component.html +++ b/libs/route-pages/services-page/src/services-page.component.html @@ -3,8 +3,8 @@

Full-cycle software development for your business

We can help you cover all aspects of software development, including UX/UI design, custom web and mobile development, QA services, business analysis, and content writing. With the help of our Technical Writers, you’ll have all the documentation ready for smooth product maintenance in the future.

-