This repository was archived by the owner on May 29, 2025. It is now read-only.
Choose new staking contracts #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoreira-valory
commented
Aug 6, 2024
Comment on lines
+651
to
+656
|
|
||
| # export CUSTOM_SERVICE_REGISTRY_ADDRESS="0x9338b5153AE39BB89f50468E608eD9d764B755fD" # Set up in .env file | ||
| # export CUSTOM_STAKING_ADDRESS="0x43fB32f25dce34EB76c78C7A42C8F40F84BCD237" # Set up in .env file | ||
| # export CUSTOM_OLAS_ADDRESS="0xcE11e14225575945b8E6Dc0D4F2dD4C570f79d9f" # Set up in .env file | ||
| # export CUSTOM_SERVICE_REGISTRY_TOKEN_UTILITY_ADDRESS="0xa45E64d13A30a51b91ae0eb182e88a40e9b18eD8" # Set up in .env file | ||
| # export MECH_CONTRACT_ADDRESS="0x77af31De935740567Cf4fF1986D04B2c964A786a" # Set up in env file |
Collaborator
Author
There was a problem hiding this comment.
@kupermind Please validate the following:
- The parameters commented correspond to addresses that depend/can be inferred from the staking contract.
- The remaining addresses not commented should remain constant for all staking contracts, for the time being.
- Please suggest a more appropriate name for any of these variables from point 1 and 2 above.
Collaborator
There was a problem hiding this comment.
CUSTOM_GNOSIS_SAFE_PROXY_FACTORY_ADDRESS => CUSTOM_GNOSIS_SAFE_MULTISIG_ADDRESS
Collaborator
Author
There was a problem hiding this comment.
These commented variables will be removed before merging to main.
0xArdi
reviewed
Aug 7, 2024
Adamantios
approved these changes
Aug 8, 2024
0xArdi
approved these changes
Aug 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose new staking contracts.
Specification:
cd trader; poetry run python ./scripts/choose_staking.py --reset; cd ..Pending to implement (in future PRs)