This repository was archived by the owner on May 29, 2025. It is now read-only.
Fix export variables on MinGW #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagacha
approved these changes
Aug 12, 2024
Collaborator
dagacha
left a comment
dagacha
left a comment
There was a problem hiding this comment.
Checked that it does not break the non-staking flow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix export variables on MinGW. This PR changes the way variables are exported.
A specific check is used for Mac. Rest of the systems (Linux, WSL2, MinGW) use the default mechanism. Note that WSL2 reports the same
unameas Ubuntu (Linux), therefore it was not causing an issue there.