Add a middleware for promoting a connection to WebSocket (fix #205)

[arteymix]

No description provided.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@97f3792). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master    #206   +/-   ##
========================================
  Coverage          ?   62.3%           
========================================
  Files             ?      40           
  Lines             ?    1369           
  Branches          ?     170           
========================================
  Hits              ?     853           
  Misses            ?     448           
  Partials          ?      68

Impacted Files	Coverage Δ
src/vsgi/vsgi-request.vala	67.37% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f3792...7360801. Read the comment docs.

[ZanderBrown]

Any chance of resurrecting this?

[arteymix]

I'll look into it tomorrow.

[arteymix]

I just tested the handshake so far, but I'll write a unit test using the client that comes with libsoup-2.4.

[ZanderBrown]

Looking good, been wanting to have a serious play with valum for a while and I now find myself needing a WebSocket server. Having looked at the insanity of doing that in PHP it seemed as good a time as any to finally get valum out.

[ZanderBrown]

Anything I could do to push this over the line?

[arteymix]

I finally managed to make it work! I'll push the testcase in a few hours (I have a course now).

[arteymix]

I wrote the test case against the example, but I'll complete it later. Meanwhile, you can test it and give it some feedback.

I'll try to fix the CI..

[ZanderBrown]

Seem to have run into some problems that seem to be around valum expecting http:// but (at least in js) only ws://(or wss://) is valid for WebSocket connections.

Also ninja seems to timeout on the websocket test and my simple soup client reports

The server did not accept the WebSocket handshake.

[ZanderBrown]

Okay pulled latest commit, now I get

ERROR:websocket-test.vala:18:__lambda5_: code should not be reached

For the test

[arteymix]

You need to start the example application to run the test until I include it in the unit test itself. I think I'll use a fork for starting the server part.

[arteymix]

I think I've found why it was not working, the Connection header can contains a param list.

I'll release a 0.4 with WebSocket support along with VSGI 1.0 soon after this get merged. I'd like to make it to the next TechEmpower benchmark!

[ZanderBrown]

Connecting to examples/app /websocket in JS seems to work for me now

[arteymix]

It was fixed in cea368d

Since it's working, I've merged the work into the trunk and I'll include the testcase later.