New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance degradation #533

Closed
kirillDanshin opened this Issue Feb 6, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@kirillDanshin
Copy link
Collaborator

kirillDanshin commented Feb 6, 2019

We somehow managed to go from 7mln rps to 4mln rps.
That must have an urgent fix.

For some more details, see TechEmpower/FrameworkBenchmarks#4410

@erikdubbelboer

This comment has been minimized.

Copy link
Collaborator

erikdubbelboer commented Feb 6, 2019

The last commit before 2018-10-30 was afcef43. I have been running benchmarks for the last couple of hours now comparing the performance of this commit against the performance of master and I can't see any difference so far. I'm thinking something went wrong when they ran their benchmark.

@philcaetano

This comment has been minimized.

Copy link

philcaetano commented Feb 6, 2019

Looking at their history, https://tfb-status.techempower.com/ It looks like the drop in performance happened between Dec 3 and Dec 14. On Dec 3 the performance was 6.6 mil after it was dropped to 4.5. There are two commits during that time. Can any of those be related?

@erikdubbelboer

This comment has been minimized.

Copy link
Collaborator

erikdubbelboer commented Feb 8, 2019

@philcaetano

Can any of those be related?

No those commits have nothing to do with performance. Neither do any of the commits before or after that.

@erikdubbelboer

This comment has been minimized.

Copy link
Collaborator

erikdubbelboer commented Feb 12, 2019

I finally found the issue and fixed it in 02b7301 🍾

@ww9

This comment has been minimized.

Copy link

ww9 commented Feb 12, 2019

That was fast!

Hope to see Go at the top 3 again, thanks to fasthttp contributors! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment