Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uri: isHttps() and isHttp() #1150

Merged
merged 2 commits into from Nov 8, 2021
Merged

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Nov 8, 2021

Use them instead of manual schema comparison.
This makes code cleaner but also opens a door for next optimizations

@erikdubbelboer
Copy link
Collaborator

erikdubbelboer commented Nov 8, 2021

Seems like TestClientDoWithCustomHeaders is failing. I'm not sure why, maybe you can investigate.

Use them instead of manual schema comparison
@stokito
Copy link
Contributor Author

stokito commented Nov 8, 2021

Sorry, did the change before going to sleep :)

@erikdubbelboer erikdubbelboer merged commit 3ff6aaa into valyala:master Nov 8, 2021
11 checks passed
@erikdubbelboer
Copy link
Collaborator

erikdubbelboer commented Nov 8, 2021

Thanks!

@stokito stokito deleted the client_is_tls branch Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants