Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: close idle connections when server shutdown #1155

Merged
merged 4 commits into from Nov 13, 2021

Conversation

ichxxx
Copy link
Contributor

@ichxxx ichxxx commented Nov 12, 2021

fixes #1103

server.go Outdated Show resolved Hide resolved
server.go Outdated Show resolved Hide resolved
server.go Outdated Show resolved Hide resolved
server_test.go Outdated Show resolved Hide resolved
server_test.go Outdated Show resolved Hide resolved
@erikdubbelboer erikdubbelboer merged commit 3b117f8 into valyala:master Nov 13, 2021
11 checks passed
@erikdubbelboer
Copy link
Collaborator

erikdubbelboer commented Nov 13, 2021

Thanks!

@edwvee
Copy link

edwvee commented Nov 14, 2021

Great thanks! Now my app can safely stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing idle connections (and improving shutdown)
3 participants