Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheme check for not yet parsed requests #1203

Merged
merged 3 commits into from Jan 31, 2022

Conversation

ArminBTVS
Copy link
Contributor

@ArminBTVS ArminBTVS commented Jan 28, 2022

At this point the request might not be parsed yet and set. In that case uri is empty and isHttps() returns always false. I don't expect this is intended?

Otherwise URL() must be called before actually passing the request to client.Do()

At this point the request might not be parsed yet and set. In that case uri is empty and isHttps() returns always false. I don't expect this is intended?

Otherwise URL() must be called before actually passing the request to client.Do()
@erikdubbelboer
Copy link
Collaborator

erikdubbelboer commented Jan 28, 2022

That makes sense. Would it be possible for you to add a test case that fails before and passes after your fix?

@ArminBTVS
Copy link
Contributor Author

ArminBTVS commented Jan 31, 2022

@erikdubbelboer sure. Added a test which would fail without the fix

@erikdubbelboer
Copy link
Collaborator

erikdubbelboer commented Jan 31, 2022

Sorry one last thing, can you fix the lining error? Thanks!

@ArminBTVS
Copy link
Contributor Author

ArminBTVS commented Jan 31, 2022

Sorry one last thing, can you fix the lining error? Thanks!

Done

@erikdubbelboer erikdubbelboer merged commit 8d7953e into valyala:master Jan 31, 2022
11 checks passed
@erikdubbelboer
Copy link
Collaborator

erikdubbelboer commented Jan 31, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants