Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to allow empty root in the fsHandler #1299

Merged
merged 4 commits into from May 16, 2022

Conversation

ReneWerner87
Copy link
Contributor

@ReneWerner87 ReneWerner87 commented May 12, 2022

Add an option to allow empty root in the fsHandler

this is necessary to restore the capabilities before the commit c7576cc
and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards

related to:
gofiber/fiber#1882 (comment)

this is necessary to restore the capabilities before the commit valyala@c7576cc
and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards

gofiber/fiber#1882 (comment)
this is necessary to restore the capabilities before the commit valyala@c7576cc
and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards

gofiber/fiber#1882 (comment)
fs.go Outdated Show resolved Hide resolved
fs.go Outdated Show resolved Hide resolved
ReneWerner87 and others added 2 commits May 16, 2022
Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
@ReneWerner87
Copy link
Contributor Author

ReneWerner87 commented May 16, 2022

@erikdubbelboer thank you for your suggestions, I have adopted them

@erikdubbelboer erikdubbelboer merged commit 66bc61e into valyala:master May 16, 2022
14 checks passed
@erikdubbelboer
Copy link
Collaborator

erikdubbelboer commented May 16, 2022

Thanks. I'll tag a new release tomorrow.

bbenzikry pushed a commit to bbenzikry/fasthttp that referenced this issue Sep 11, 2022
* Add an option to allow empty root in the fsHandler

this is necessary to restore the capabilities before the commit valyala@c7576cc
and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards

gofiber/fiber#1882 (comment)

* Add an option to allow empty root in the fsHandler

this is necessary to restore the capabilities before the commit valyala@c7576cc
and to allow further functionality to be docked from the outside which is not affected by setting the root dir afterwards

gofiber/fiber#1882 (comment)

* Update fs.go

Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>

* Update fs.go

Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>

Co-authored-by: Erik Dubbelboer <erik@dubbelboer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants