Prevent overflow and panic on large HTTP responses #1351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The
round2
function inhttp.go
didn't check for overflow when converting auint32
value +1 to anint
. As a result, it could return 0 for large values, and hence attempting to handle a large response could result in a panic:This patch fixes round2 to return a maximum value of
math.MaxInt32
, which seems to make sense given that the calculation is done using auint32
, and you probably don't want a bigger buffer than that even on 64 bit systems.