Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go 1.19 Support #1355

Merged
merged 6 commits into from Aug 14, 2022
Merged

Conversation

Aoang
Copy link
Contributor

@Aoang Aoang commented Aug 14, 2022

No description provided.

Aoang added 5 commits Aug 14, 2022
Go 1.19 adds support for links, lists, and clearer headings in doc comments. As part of this change, gofmt now reformats doc comments to make their rendered meaning clearer. See “Go Doc Comments” for syntax details and descriptions of common mistakes now highlighted by gofmt. As another part of this change, the new package go/doc/comment provides parsing and reformatting of doc comments as well as support for rendering them to HTML, Markdown, and text.

ref: https://tip.golang.org/doc/go1.19
ref: https://tip.golang.org/doc/comment
@Aoang Aoang changed the title [WIP] Add Go 1.19 Support Add Go 1.19 Support Aug 14, 2022
@Aoang
Copy link
Contributor Author

Aoang commented Aug 14, 2022

TBR

Copy link
Collaborator

@erikdubbelboer erikdubbelboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Super nice pull request, just 2 minor fixes needed.

doc.go Outdated
- Server and client address.

- Per-request logger.

- Unique request id.

- Request start time.

- Connection start time.

- Request sequence number for the current connection.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be sub bullet points like the original.

doc.go Outdated
- The number of concurrent connections.

- The number of concurrent connections per client IP.

- The number of requests per connection.

- Request read timeout.

- Response write timeout.

- Maximum request header size.

- Maximum request body size.

- Maximum request execution time.

- Maximum keep-alive connection lifetime.

- Early filtering out non-GET requests.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be sub bullet points like the original.

@Aoang
Copy link
Contributor Author

Aoang commented Aug 14, 2022

@erikdubbelboer Go doc comments do not support nested lists. https://tip.golang.org/doc/comment#mistakes

Maybe we can mix list markers like the example? Since bullet markers do not introduce list items in a numbered list.

@erikdubbelboer erikdubbelboer merged commit ea60524 into valyala:master Aug 14, 2022
17 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

@Aoang Aoang deleted the add-go-1-19-support branch Aug 14, 2022
go-version: 1.18.x
go-version: 1.19.x

- name: Get Go cache paths

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aoang curious why you ended up doing this? In wazero, we're noticing the cache doesn't seem to work for golangci-lint and wondering if there's some difference between this and hard-coding (considering it is only run with ubuntu). Any thoughts appreciated!

https://github.com/tetratelabs/wazero/blob/main/.github/workflows/commit.yaml#L46-L52

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bbenzikry pushed a commit to bbenzikry/fasthttp that referenced this pull request Sep 11, 2022
* Update Go Version to Go1.19.x And add cache

* Fix CI Line endings

* Update test CI Go Version to Go1.19.x And add cache

* Update Gosec Security Scanner CI to securego/gosec@v2.12.0

* Format comment

Go 1.19 adds support for links, lists, and clearer headings in doc comments. As part of this change, gofmt now reformats doc comments to make their rendered meaning clearer. See “Go Doc Comments” for syntax details and descriptions of common mistakes now highlighted by gofmt. As another part of this change, the new package go/doc/comment provides parsing and reformatting of doc comments as well as support for rendering them to HTML, Markdown, and text.

ref: https://tip.golang.org/doc/go1.19
ref: https://tip.golang.org/doc/comment

* Fix doc structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants