Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PeekKeys and PeekTrailerKeys #1405

Merged
merged 2 commits into from Oct 29, 2022

Conversation

li-jin-gou
Copy link
Contributor

@li-jin-gou li-jin-gou commented Oct 22, 2022

pr for #1400

header.go Outdated
@@ -43,6 +43,7 @@ type ResponseHeader struct {
contentEncoding []byte
server []byte
mulHeader [][]byte
keys [][]byte
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can re-use mulHeader for this. But I do think we need to improve the warning for these and the PeekAll functions to make it clear that any further calls to Peek* functions will also change the return values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified the code and added the relevant code comments

header.go Outdated Show resolved Hide resolved
header.go Outdated Show resolved Hide resolved
header.go Outdated Show resolved Hide resolved
header.go Outdated Show resolved Hide resolved
header.go Outdated Show resolved Hide resolved
header.go Outdated Show resolved Hide resolved
@erikdubbelboer erikdubbelboer merged commit 3963a79 into valyala:master Oct 29, 2022
14 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants